| Message ID | 1405114551-24354-2-git-send-email-aduggan@synaptics.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Jul 11 2014 or thereabouts, Andrew Duggan wrote: > Userspace tools may use hidraw to perform operations on the device from userspace while > hid-rmi is bound to the device. This can cause hid-rmi to print error messages when its > ->raw_event() callback gets called as the reports pass through the HID stack. In this case > receiving responses which were not initiated by hid-rmi is not actually an error so the resulting > error messages are incorrect and misleading. This patch changes the log messages to debug so > that the messages can be turned on in the event that there is a problem and there is not > a userspace tool running. > > Signed-off-by: Andrew Duggan <aduggan@synaptics.com> > --- Fair enough Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cheers, Benjamin > drivers/hid/hid-rmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c > index 578bbe6..25f571a 100644 > --- a/drivers/hid/hid-rmi.c > +++ b/drivers/hid/hid-rmi.c > @@ -377,7 +377,7 @@ static int rmi_input_event(struct hid_device *hdev, u8 *data, int size) > irq_mask |= hdata->f30.irq_mask; > > if (data[1] & ~irq_mask) > - hid_warn(hdev, "unknown intr source:%02lx %s:%d\n", > + hid_dbg(hdev, "unknown intr source:%02lx %s:%d\n", > data[1] & ~irq_mask, __FILE__, __LINE__); > > if (hdata->f11.interrupt_base < hdata->f30.interrupt_base) { > @@ -400,7 +400,7 @@ static int rmi_read_data_event(struct hid_device *hdev, u8 *data, int size) > struct rmi_data *hdata = hid_get_drvdata(hdev); > > if (!test_bit(RMI_READ_REQUEST_PENDING, &hdata->flags)) { > - hid_err(hdev, "no read request pending\n"); > + hid_dbg(hdev, "no read request pending\n"); > return 0; > } > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 15 Jul 2014, Benjamin Tissoires wrote: > On Jul 11 2014 or thereabouts, Andrew Duggan wrote: > > Userspace tools may use hidraw to perform operations on the device from userspace while > > hid-rmi is bound to the device. This can cause hid-rmi to print error messages when its > > ->raw_event() callback gets called as the reports pass through the HID stack. In this case > > receiving responses which were not initiated by hid-rmi is not actually an error so the resulting > > error messages are incorrect and misleading. This patch changes the log messages to debug so > > that the messages can be turned on in the event that there is a problem and there is not > > a userspace tool running. > > > > Signed-off-by: Andrew Duggan <aduggan@synaptics.com> > > --- > > Fair enough > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> [ sorry for late response, I am just re-appearing from vacation-land ] Applied, thanks.
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 578bbe6..25f571a 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -377,7 +377,7 @@ static int rmi_input_event(struct hid_device *hdev, u8 *data, int size) irq_mask |= hdata->f30.irq_mask; if (data[1] & ~irq_mask) - hid_warn(hdev, "unknown intr source:%02lx %s:%d\n", + hid_dbg(hdev, "unknown intr source:%02lx %s:%d\n", data[1] & ~irq_mask, __FILE__, __LINE__); if (hdata->f11.interrupt_base < hdata->f30.interrupt_base) { @@ -400,7 +400,7 @@ static int rmi_read_data_event(struct hid_device *hdev, u8 *data, int size) struct rmi_data *hdata = hid_get_drvdata(hdev); if (!test_bit(RMI_READ_REQUEST_PENDING, &hdata->flags)) { - hid_err(hdev, "no read request pending\n"); + hid_dbg(hdev, "no read request pending\n"); return 0; }
Userspace tools may use hidraw to perform operations on the device from userspace while hid-rmi is bound to the device. This can cause hid-rmi to print error messages when its ->raw_event() callback gets called as the reports pass through the HID stack. In this case receiving responses which were not initiated by hid-rmi is not actually an error so the resulting error messages are incorrect and misleading. This patch changes the log messages to debug so that the messages can be turned on in the event that there is a problem and there is not a userspace tool running. Signed-off-by: Andrew Duggan <aduggan@synaptics.com> --- drivers/hid/hid-rmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)