diff mbox

ARM: shmobile: Use shmobile_init_delay() on APE6EVM

Message ID 20140730234500.18995.49199.sendpatchset@w520 (mailing list archive)
State Accepted
Headers show

Commit Message

Magnus Damm July 30, 2014, 11:45 p.m. UTC 
From: Magnus Damm <damm+renesas@opensource.se>

The r8a73a4 DTS includes CPU Frequency information so
adjust the APE6EVM board code to use shmobile_init_delay()
instead of relying on CPU Frequency information included
in r8a73a4_init_delay() that is specified in C.

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 Written on top of renesas-devel-v3.16-rc7-20140729 and
 [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()

 arch/arm/mach-shmobile/board-ape6evm-reference.c |    2 +-
 arch/arm/mach-shmobile/board-ape6evm.c           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Simon Horman July 31, 2014, 12:12 a.m. UTC | #1 
On Thu, Jul 31, 2014 at 08:45:00AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
> 
> The r8a73a4 DTS includes CPU Frequency information so
> adjust the APE6EVM board code to use shmobile_init_delay()
> instead of relying on CPU Frequency information included
> in r8a73a4_init_delay() that is specified in C.
> 
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
> 
>  Written on top of renesas-devel-v3.16-rc7-20140729 and
>  [PATCH 00/09] ARM: shmobile: Consistent use of shmobile_init_late()

Hi Magnus,

As per my comment on "[PATCH 00/09] ARM: shmobile: Consistent use of
shmobile_init_late()".

These patches seem fine for me but I wonder if you could follow the
convention that has emerged as being dominant for subjects

* Using lowercase for SOC names
* Omitting hyphens from boards names (i.e. bockw)
* Putting the board or soc after "shmobile: " and followed by a ':'.

I have taken the liberty of updating the patch name to the
following and queued up the result:

ARM: shmobile: ape6evm: Use shmobile_init_delay()
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- 0002/arch/arm/mach-shmobile/board-ape6evm-reference.c
+++ work/arch/arm/mach-shmobile/board-ape6evm-reference.c	2014-07-31 08:38:10.000000000 +0900
@@ -59,7 +59,7 @@  static const char *ape6evm_boards_compat
 };
 
 DT_MACHINE_START(APE6EVM_DT, "ape6evm")
-	.init_early	= r8a73a4_init_early,
+	.init_early	= shmobile_init_delay,
 	.init_machine	= ape6evm_add_standard_devices,
 	.init_late	= shmobile_init_late,
 	.dt_compat	= ape6evm_boards_compat_dt,
--- 0002/arch/arm/mach-shmobile/board-ape6evm.c
+++ work/arch/arm/mach-shmobile/board-ape6evm.c	2014-07-31 08:39:22.000000000 +0900
@@ -283,7 +283,7 @@  static const char *ape6evm_boards_compat
 };
 
 DT_MACHINE_START(APE6EVM_DT, "ape6evm")
-	.init_early	= r8a73a4_init_early,
+	.init_early	= shmobile_init_delay,
 	.init_machine	= ape6evm_add_standard_devices,
 	.init_late	= shmobile_init_late,
 	.dt_compat	= ape6evm_boards_compat_dt,