| Message ID | 1407307928-13652-1-git-send-email-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 08/06/2014 08:52 AM, Sakari Ailus wrote: > Constify event type constants and correct motion detection event number > (it's 6, not 5). > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Regards, Hans > --- > Thanks for the review, Hans! > > Since v1: > > - No line breaks between <constant> and </constant>. No other changes. > > Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++--- > Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml > index cb77325..b036f89 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml > @@ -76,21 +76,22 @@ > <entry></entry> > <entry>&v4l2-event-vsync;</entry> > <entry><structfield>vsync</structfield></entry> > - <entry>Event data for event V4L2_EVENT_VSYNC. > + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>. > </entry> > </row> > <row> > <entry></entry> > <entry>&v4l2-event-ctrl;</entry> > <entry><structfield>ctrl</structfield></entry> > - <entry>Event data for event V4L2_EVENT_CTRL. > + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>. > </entry> > </row> > <row> > <entry></entry> > <entry>&v4l2-event-frame-sync;</entry> > <entry><structfield>frame_sync</structfield></entry> > - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry> > + <entry>Event data for event > + <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry> > </row> > <row> > <entry></entry> > diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml > index 9f60956..d7c9365 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml > @@ -176,7 +176,7 @@ > </row> > <row> > <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry> > - <entry>5</entry> > + <entry>6</entry> > <entry> > <para>Triggered whenever the motion detection state for one or more of the regions > changes. This event has a &v4l2-event-motion-det; associated with it.</para> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/06/2014 08:52 AM, Sakari Ailus wrote: > Constify event type constants and correct motion detection event number > (it's 6, not 5). > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > --- > Thanks for the review, Hans! > > Since v1: > > - No line breaks between <constant> and </constant>. No other changes. > > Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++--- > Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml > index cb77325..b036f89 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml > @@ -76,21 +76,22 @@ > <entry></entry> > <entry>&v4l2-event-vsync;</entry> > <entry><structfield>vsync</structfield></entry> > - <entry>Event data for event V4L2_EVENT_VSYNC. > + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>. > </entry> > </row> > <row> > <entry></entry> > <entry>&v4l2-event-ctrl;</entry> > <entry><structfield>ctrl</structfield></entry> > - <entry>Event data for event V4L2_EVENT_CTRL. > + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>. > </entry> > </row> > <row> > <entry></entry> > <entry>&v4l2-event-frame-sync;</entry> > <entry><structfield>frame_sync</structfield></entry> > - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry> > + <entry>Event data for event > + <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry> > </row> > <row> > <entry></entry> > diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml > index 9f60956..d7c9365 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml > @@ -176,7 +176,7 @@ > </row> > <row> > <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry> > - <entry>5</entry> > + <entry>6</entry> > <entry> > <para>Triggered whenever the motion detection state for one or more of the regions > changes. This event has a &v4l2-event-motion-det; associated with it.</para> > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/07/2014 08:50 AM, Hans Verkuil wrote: > On 08/06/2014 08:52 AM, Sakari Ailus wrote: >> Constify event type constants and correct motion detection event number >> (it's 6, not 5). >> >> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Hmm, I did that already. Oh well, you can never have too many acks :-) > >> --- >> Thanks for the review, Hans! >> >> Since v1: >> >> - No line breaks between <constant> and </constant>. No other changes. >> >> Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++--- >> Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +- >> 2 files changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml >> index cb77325..b036f89 100644 >> --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml >> +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml >> @@ -76,21 +76,22 @@ >> <entry></entry> >> <entry>&v4l2-event-vsync;</entry> >> <entry><structfield>vsync</structfield></entry> >> - <entry>Event data for event V4L2_EVENT_VSYNC. >> + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>. >> </entry> >> </row> >> <row> >> <entry></entry> >> <entry>&v4l2-event-ctrl;</entry> >> <entry><structfield>ctrl</structfield></entry> >> - <entry>Event data for event V4L2_EVENT_CTRL. >> + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>. >> </entry> >> </row> >> <row> >> <entry></entry> >> <entry>&v4l2-event-frame-sync;</entry> >> <entry><structfield>frame_sync</structfield></entry> >> - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry> >> + <entry>Event data for event >> + <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry> >> </row> >> <row> >> <entry></entry> >> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml >> index 9f60956..d7c9365 100644 >> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml >> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml >> @@ -176,7 +176,7 @@ >> </row> >> <row> >> <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry> >> - <entry>5</entry> >> + <entry>6</entry> >> <entry> >> <para>Triggered whenever the motion detection state for one or more of the regions >> changes. This event has a &v4l2-event-motion-det; associated with it.</para> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml index cb77325..b036f89 100644 --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml @@ -76,21 +76,22 @@ <entry></entry> <entry>&v4l2-event-vsync;</entry> <entry><structfield>vsync</structfield></entry> - <entry>Event data for event V4L2_EVENT_VSYNC. + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>. </entry> </row> <row> <entry></entry> <entry>&v4l2-event-ctrl;</entry> <entry><structfield>ctrl</structfield></entry> - <entry>Event data for event V4L2_EVENT_CTRL. + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>. </entry> </row> <row> <entry></entry> <entry>&v4l2-event-frame-sync;</entry> <entry><structfield>frame_sync</structfield></entry> - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry> + <entry>Event data for event + <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry> </row> <row> <entry></entry> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml index 9f60956..d7c9365 100644 --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml @@ -176,7 +176,7 @@ </row> <row> <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry> - <entry>5</entry> + <entry>6</entry> <entry> <para>Triggered whenever the motion detection state for one or more of the regions changes. This event has a &v4l2-event-motion-det; associated with it.</para>
Constify event type constants and correct motion detection event number (it's 6, not 5). Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- Thanks for the review, Hans! Since v1: - No line breaks between <constant> and </constant>. No other changes. Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++--- Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-)