| Message ID | 1407409120-23635-1-git-send-email-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 7, 2014 at 7:58 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space" > error exposed by new versions of the designware pcie driver. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > arch/arm/boot/dts/imx6qdl.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index ce0599134a69..6b5da2a98aaf 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -133,7 +133,9 @@ > > pcie: pcie@0x01000000 { > compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; > - reg = <0x01ffc000 0x4000>; /* DBI */ > + reg = <0x01ffc000 0x04000>, > + <0x01f00000 0x80000>; > + reg-names = "dbi", "config"; Please update Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt as well.
Am Donnerstag, den 07.08.2014, 08:53 -0300 schrieb Fabio Estevam: > On Thu, Aug 7, 2014 at 7:58 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > > Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space" > > error exposed by new versions of the designware pcie driver. > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > --- > > arch/arm/boot/dts/imx6qdl.dtsi | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > > index ce0599134a69..6b5da2a98aaf 100644 > > --- a/arch/arm/boot/dts/imx6qdl.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > > @@ -133,7 +133,9 @@ > > > > pcie: pcie@0x01000000 { > > compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; > > - reg = <0x01ffc000 0x4000>; /* DBI */ > > + reg = <0x01ffc000 0x04000>, > > + <0x01f00000 0x80000>; > > + reg-names = "dbi", "config"; > > > Please update Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt as well. The binding for this is part of the common designware binding. See Documentation/devicetree/bindings/pci/designware-pcie.txt Regards, Lucas
On Thu, Aug 7, 2014 at 9:19 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > The binding for this is part of the common designware binding. See > Documentation/devicetree/bindings/pci/designware-pcie.txt The example section in imx6q-pcie.txt should be in sync with the pci node from imx6qdl.dtsi, right?
Am Donnerstag, den 07.08.2014, 09:29 -0300 schrieb Fabio Estevam: > On Thu, Aug 7, 2014 at 9:19 AM, Lucas Stach <l.stach@pengutronix.de> wrote: > > > The binding for this is part of the common designware binding. See > > Documentation/devicetree/bindings/pci/designware-pcie.txt > > The example section in imx6q-pcie.txt should be in sync with the pci > node from imx6qdl.dtsi, right? > Right, will fix this. Regards, Lucas
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index ce0599134a69..6b5da2a98aaf 100644 --- a/arch/arm/boot/dts/imx6qdl.dtsi +++ b/arch/arm/boot/dts/imx6qdl.dtsi @@ -133,7 +133,9 @@ pcie: pcie@0x01000000 { compatible = "fsl,imx6q-pcie", "snps,dw-pcie"; - reg = <0x01ffc000 0x4000>; /* DBI */ + reg = <0x01ffc000 0x04000>, + <0x01f00000 0x80000>; + reg-names = "dbi", "config"; #address-cells = <3>; #size-cells = <2>; device_type = "pci";
Fixes "imx6q-pcie 1ffc000.pcie: missing *config* reg space" error exposed by new versions of the designware pcie driver. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- arch/arm/boot/dts/imx6qdl.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)