| Message ID | 1407482097-17624-1-git-send-email-kiran.padwal@smartplayin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Aug 08, 2014 at 12:44:57PM +0530, Kiran Padwal wrote: > There is no need to print out-of-memory errors since this is already > done by the memory management subsystem which even calls dump_stack(). This is implementation detail as far as I am concerned. We might switch dumping stack off down the road. Thanks. > > Signed-off-by: Kiran Padwal <kiran.padwal@smartplayin.com> > --- > drivers/input/misc/da9055_onkey.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/misc/da9055_onkey.c b/drivers/input/misc/da9055_onkey.c > index 4765799..ed6eaa9 100644 > --- a/drivers/input/misc/da9055_onkey.c > +++ b/drivers/input/misc/da9055_onkey.c > @@ -87,10 +87,8 @@ static int da9055_onkey_probe(struct platform_device *pdev) > } > > onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL); > - if (!onkey) { > - dev_err(&pdev->dev, "Failed to allocate memory\n"); > + if (!onkey) > return -ENOMEM; > - } > > input_dev = input_allocate_device(); > if (!input_dev) { > -- > 1.7.9.5 >
diff --git a/drivers/input/misc/da9055_onkey.c b/drivers/input/misc/da9055_onkey.c index 4765799..ed6eaa9 100644 --- a/drivers/input/misc/da9055_onkey.c +++ b/drivers/input/misc/da9055_onkey.c @@ -87,10 +87,8 @@ static int da9055_onkey_probe(struct platform_device *pdev) } onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL); - if (!onkey) { - dev_err(&pdev->dev, "Failed to allocate memory\n"); + if (!onkey) return -ENOMEM; - } input_dev = input_allocate_device(); if (!input_dev) {
There is no need to print out-of-memory errors since this is already done by the memory management subsystem which even calls dump_stack(). Signed-off-by: Kiran Padwal <kiran.padwal@smartplayin.com> --- drivers/input/misc/da9055_onkey.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)