mbox series

[v2,0/4] ASoC: Intel: Add KeemBay ASoC driver

Message ID 1589768242-4594-1-git-send-email-jee.heng.sia@intel.com (mailing list archive)
Headers show
Series ASoC: Intel: Add KeemBay ASoC driver | expand

Message

Sia Jee Heng May 18, 2020, 2:17 a.m. UTC
The below series of patches support the KeemBay ASoC driver.
It enabled the tlv320aic3204 machine driver and the platform driver initialize
the i2s to capture and playback the pcm data on the ARM. The i2s is running
in polling mode.

There is no DSP in the KeemBay SoC. Users are rely on the Gstreamer plugin
to perform some Audio preprocessing.

Change History:
v2:
- Corrected I2S naming for DT binding.
  
v1:
- Initial version.

Sia Jee Heng (4):
  ASoC: Intel: Add KeemBay platform driver
  ASoC: Intel: Boards: Add KeemBay machine driver
  ASoC: Intel: Add makefiles and kconfig changes for KeemBay
  dt-bindings: sound: Add documentation for KeemBay sound card and i2s

 .../bindings/sound/intel,keembay-i2s.yaml          |  57 ++
 .../bindings/sound/intel,keembay-sound-card.yaml   |  30 +
 sound/soc/intel/Kconfig                            |   7 +
 sound/soc/intel/Makefile                           |   1 +
 sound/soc/intel/boards/Kconfig                     |  15 +
 sound/soc/intel/boards/Makefile                    |   4 +
 sound/soc/intel/boards/kmb_tlv3204.c               | 144 ++++
 sound/soc/intel/keembay/Makefile                   |   4 +
 sound/soc/intel/keembay/kmb_platform.c             | 746 +++++++++++++++++++++
 sound/soc/intel/keembay/kmb_platform.h             | 145 ++++
 10 files changed, 1153 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/intel,keembay-sound-card.yaml
 create mode 100644 sound/soc/intel/boards/kmb_tlv3204.c
 create mode 100644 sound/soc/intel/keembay/Makefile
 create mode 100644 sound/soc/intel/keembay/kmb_platform.c
 create mode 100644 sound/soc/intel/keembay/kmb_platform.h

Comments

Pierre-Louis Bossart May 18, 2020, 4:38 p.m. UTC | #1
On 5/17/20 9:17 PM, Sia Jee Heng wrote:
> The below series of patches support the KeemBay ASoC driver.
> It enabled the tlv320aic3204 machine driver and the platform driver initialize
> the i2s to capture and playback the pcm data on the ARM. The i2s is running
> in polling mode.
> 
> There is no DSP in the KeemBay SoC. Users are rely on the Gstreamer plugin
> to perform some Audio preprocessing.

This patch series matches what was reviewed internally at Intel by Andy 
Shevchenko, Cezary and I, so for patches 1..3:

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Note that my review is mostly high-level, I don't personally have any 
knowledge or detailed information on this IP and architecture.

> 
> Change History:
> v2:
> - Corrected I2S naming for DT binding.
>    
> v1:
> - Initial version.
> 
> Sia Jee Heng (4):
>    ASoC: Intel: Add KeemBay platform driver
>    ASoC: Intel: Boards: Add KeemBay machine driver
>    ASoC: Intel: Add makefiles and kconfig changes for KeemBay
>    dt-bindings: sound: Add documentation for KeemBay sound card and i2s
> 
>   .../bindings/sound/intel,keembay-i2s.yaml          |  57 ++
>   .../bindings/sound/intel,keembay-sound-card.yaml   |  30 +
>   sound/soc/intel/Kconfig                            |   7 +
>   sound/soc/intel/Makefile                           |   1 +
>   sound/soc/intel/boards/Kconfig                     |  15 +
>   sound/soc/intel/boards/Makefile                    |   4 +
>   sound/soc/intel/boards/kmb_tlv3204.c               | 144 ++++
>   sound/soc/intel/keembay/Makefile                   |   4 +
>   sound/soc/intel/keembay/kmb_platform.c             | 746 +++++++++++++++++++++
>   sound/soc/intel/keembay/kmb_platform.h             | 145 ++++
>   10 files changed, 1153 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml
>   create mode 100644 Documentation/devicetree/bindings/sound/intel,keembay-sound-card.yaml
>   create mode 100644 sound/soc/intel/boards/kmb_tlv3204.c
>   create mode 100644 sound/soc/intel/keembay/Makefile
>   create mode 100644 sound/soc/intel/keembay/kmb_platform.c
>   create mode 100644 sound/soc/intel/keembay/kmb_platform.h
>