mbox series

[v2,0/5] ASoC: Mediatek: Add support for MT8192 SoC

Message ID 1603270435-3548-1-git-send-email-jiaxin.yu@mediatek.com (mailing list archive)
Headers show
Series ASoC: Mediatek: Add support for MT8192 SoC | expand

Message

Jiaxin Yu Oct. 21, 2020, 8:53 a.m. UTC
This series of patches adds support for Mediatek AFE for MT8192 SoC. At the same
time, the calibration function of MT6359 is completed with real machine driver.
The patch is based on broonie tree "for-next" branch.

Change since v1:
  - fixed some typos related to dt-bindings in [v1,3/5] and [v1,5/5]
  - add vendor prefix to the properties, such as "mediatek,apmixedsys"
  - add a dependency description to indicate the required header files

Jiaxin Yu (5):
  ASoC: mediatek: mt6359: add the calibration functions
  ASoC: mediatek: mt8192: add platform driver
  dt-bindings: mediatek: mt8192: add audio afe document
  ASoC: mediatek: mt8192: add machine driver with mt6359, rt1015 and
    rt5682
  dt-bindings: mediatek: mt8192: add mt8192-mt6358-rt1015-rt5682
    document

 .../bindings/sound/mt8192-afe-pcm.yaml        |  103 +
 .../sound/mt8192-mt6359-rt1015-rt5682.yaml    |   42 +
 sound/soc/codecs/mt6359.c                     |  110 +
 sound/soc/codecs/mt6359.h                     |    7 +
 sound/soc/mediatek/Kconfig                    |   23 +
 sound/soc/mediatek/Makefile                   |    1 +
 sound/soc/mediatek/common/mtk-afe-fe-dai.c    |   13 +-
 sound/soc/mediatek/common/mtk-base-afe.h      |    1 +
 sound/soc/mediatek/mt8192/Makefile            |   16 +
 sound/soc/mediatek/mt8192/mt8192-afe-clk.c    |  669 ++++
 sound/soc/mediatek/mt8192/mt8192-afe-clk.h    |  244 ++
 sound/soc/mediatek/mt8192/mt8192-afe-common.h |  170 +
 .../soc/mediatek/mt8192/mt8192-afe-control.c  |  163 +
 sound/soc/mediatek/mt8192/mt8192-afe-gpio.c   |  306 ++
 sound/soc/mediatek/mt8192/mt8192-afe-gpio.h   |   19 +
 sound/soc/mediatek/mt8192/mt8192-afe-pcm.c    | 2389 +++++++++++++
 sound/soc/mediatek/mt8192/mt8192-dai-adda.c   | 1489 ++++++++
 sound/soc/mediatek/mt8192/mt8192-dai-i2s.c    | 2139 +++++++++++
 sound/soc/mediatek/mt8192/mt8192-dai-pcm.c    |  409 +++
 sound/soc/mediatek/mt8192/mt8192-dai-tdm.c    |  778 ++++
 .../mediatek/mt8192/mt8192-interconnection.h  |   65 +
 .../mt8192/mt8192-mt6359-rt1015-rt5682.c      | 1058 ++++++
 sound/soc/mediatek/mt8192/mt8192-reg.h        | 3131 +++++++++++++++++
 23 files changed, 13341 insertions(+), 4 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml
 create mode 100644 sound/soc/mediatek/mt8192/Makefile
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-clk.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-clk.h
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-common.h
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-control.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-gpio.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-gpio.h
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-afe-pcm.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-dai-adda.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-dai-i2s.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-dai-pcm.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-dai-tdm.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-interconnection.h
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-mt6359-rt1015-rt5682.c
 create mode 100644 sound/soc/mediatek/mt8192/mt8192-reg.h

Comments

Mark Brown Oct. 21, 2020, 1:23 p.m. UTC | #1
On Wed, Oct 21, 2020 at 04:53:52PM +0800, Jiaxin Yu wrote:
> This patch adds mt8192 platform and affiliated drivers.
> 
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> ---
>  sound/soc/mediatek/Kconfig                    |   10 +
>  sound/soc/mediatek/Makefile                   |    1 +
>  sound/soc/mediatek/common/mtk-afe-fe-dai.c    |   13 +-
>  sound/soc/mediatek/common/mtk-base-afe.h      |    1 +
>  sound/soc/mediatek/mt8192/Makefile            |   14 +
>  sound/soc/mediatek/mt8192/mt8192-afe-clk.c    |  669 ++++
>  sound/soc/mediatek/mt8192/mt8192-afe-clk.h    |  244 ++
>  sound/soc/mediatek/mt8192/mt8192-afe-common.h |  170 +
>  .../soc/mediatek/mt8192/mt8192-afe-control.c  |  163 +
>  sound/soc/mediatek/mt8192/mt8192-afe-gpio.c   |  306 ++
>  sound/soc/mediatek/mt8192/mt8192-afe-gpio.h   |   19 +
>  sound/soc/mediatek/mt8192/mt8192-afe-pcm.c    | 2389 +++++++++++++
>  sound/soc/mediatek/mt8192/mt8192-dai-adda.c   | 1489 ++++++++
>  sound/soc/mediatek/mt8192/mt8192-dai-i2s.c    | 2139 +++++++++++
>  sound/soc/mediatek/mt8192/mt8192-dai-pcm.c    |  409 +++
>  sound/soc/mediatek/mt8192/mt8192-dai-tdm.c    |  778 ++++
>  .../mediatek/mt8192/mt8192-interconnection.h  |   65 +
>  sound/soc/mediatek/mt8192/mt8192-reg.h        | 3131 +++++++++++++++++
>  18 files changed, 12006 insertions(+), 4 deletions(-)

This is *way* too big to be a single patch, please split it up - it's
over 600K.
Jiaxin Yu Oct. 22, 2020, 10:04 a.m. UTC | #2
On Wed, 2020-10-21 at 14:23 +0100, Mark Brown wrote:
> On Wed, Oct 21, 2020 at 04:53:52PM +0800, Jiaxin Yu wrote:
> > This patch adds mt8192 platform and affiliated drivers.
> > 
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
> > ---
> >  sound/soc/mediatek/Kconfig                    |   10 +
> >  sound/soc/mediatek/Makefile                   |    1 +
> >  sound/soc/mediatek/common/mtk-afe-fe-dai.c    |   13 +-
> >  sound/soc/mediatek/common/mtk-base-afe.h      |    1 +
> >  sound/soc/mediatek/mt8192/Makefile            |   14 +
> >  sound/soc/mediatek/mt8192/mt8192-afe-clk.c    |  669 ++++
> >  sound/soc/mediatek/mt8192/mt8192-afe-clk.h    |  244 ++
> >  sound/soc/mediatek/mt8192/mt8192-afe-common.h |  170 +
> >  .../soc/mediatek/mt8192/mt8192-afe-control.c  |  163 +
> >  sound/soc/mediatek/mt8192/mt8192-afe-gpio.c   |  306 ++
> >  sound/soc/mediatek/mt8192/mt8192-afe-gpio.h   |   19 +
> >  sound/soc/mediatek/mt8192/mt8192-afe-pcm.c    | 2389 +++++++++++++
> >  sound/soc/mediatek/mt8192/mt8192-dai-adda.c   | 1489 ++++++++
> >  sound/soc/mediatek/mt8192/mt8192-dai-i2s.c    | 2139 +++++++++++
> >  sound/soc/mediatek/mt8192/mt8192-dai-pcm.c    |  409 +++
> >  sound/soc/mediatek/mt8192/mt8192-dai-tdm.c    |  778 ++++
> >  .../mediatek/mt8192/mt8192-interconnection.h  |   65 +
> >  sound/soc/mediatek/mt8192/mt8192-reg.h        | 3131 +++++++++++++++++
> >  18 files changed, 12006 insertions(+), 4 deletions(-)
> 
> This is *way* too big to be a single patch, please split it up - it's
> over 600K.

I will split the dai driver files as a seperate patches. Such as:
ASoC: mediatek: mt8192: support adda in platform driver
ASoC: mediatek: mt8192: support i2s in platform driver
ASoC: mediatek: mt8192: support pcm in platform driver
ASoC: mediatek: mt8192: support tdm in platform driver
They're still in series of "ASoC: mediatek: mt8192: add platform
driver". 
Is this appropriate? Please correct me if there is any misunderstanding.
Mark Brown Oct. 22, 2020, 12:05 p.m. UTC | #3
On Thu, Oct 22, 2020 at 06:04:44PM +0800, Jiaxin Yu wrote:
> On Wed, 2020-10-21 at 14:23 +0100, Mark Brown wrote:

> > This is *way* too big to be a single patch, please split it up - it's
> > over 600K.

> I will split the dai driver files as a seperate patches. Such as:
> ASoC: mediatek: mt8192: support adda in platform driver
> ASoC: mediatek: mt8192: support i2s in platform driver
> ASoC: mediatek: mt8192: support pcm in platform driver
> ASoC: mediatek: mt8192: support tdm in platform driver
> They're still in series of "ASoC: mediatek: mt8192: add platform
> driver". 
> Is this appropriate? Please correct me if there is any misunderstanding.

That should help, yes.