[0/3] Fix Tegra194 HDA regression

Message

Sameer Pujar Dec. 7, 2021, 6:32 a.m. UTC

HDA probe failure is observed on Tegra194 based platforms and this
happens due to a reset failure. The series fixes this problem by
avoiding explicit resets on BPMP based devices.

Sameer Pujar (3):
  ALSA: hda/tegra: Skip reset on BPMP devices
  dt-bindings: sound: tegra: Update HDA resets
  arm64: tegra: Remove non existent Tegra194 reset

 .../bindings/sound/nvidia,tegra30-hda.yaml         | 13 ++++++++----
 arch/arm64/boot/dts/nvidia/tegra194.dtsi           |  5 ++---
 sound/pci/hda/hda_tegra.c                          | 24 +++++++++++++++++-----
 3 files changed, 30 insertions(+), 12 deletions(-)

Comments

Takashi Iwai Dec. 7, 2021, 8:04 a.m. UTC | #1

On Tue, 07 Dec 2021 07:32:47 +0100,
Sameer Pujar wrote:
> 
> HDA probe failure is observed on Tegra194 based platforms and this
> happens due to a reset failure. The series fixes this problem by
> avoiding explicit resets on BPMP based devices.
> 
> Sameer Pujar (3):
>   ALSA: hda/tegra: Skip reset on BPMP devices
>   dt-bindings: sound: tegra: Update HDA resets
>   arm64: tegra: Remove non existent Tegra194 reset

The change in HDA drier looks fine, and the question how to take those
patches.  If other people can give acks, I can take those to sound.git
tree destined for 5.16.

Or, if anyone else prefers taking those, feel free to do: for the
first patch,

Reviewed-by: Takashi Iwai <[e-mail]>


thanks,

Takashi

Thierry Reding Dec. 7, 2021, 8:21 a.m. UTC | #2

On Tue, Dec 07, 2021 at 09:04:54AM +0100, Takashi Iwai wrote:
> On Tue, 07 Dec 2021 07:32:47 +0100,
> Sameer Pujar wrote:
> > 
> > HDA probe failure is observed on Tegra194 based platforms and this
> > happens due to a reset failure. The series fixes this problem by
> > avoiding explicit resets on BPMP based devices.
> > 
> > Sameer Pujar (3):
> >   ALSA: hda/tegra: Skip reset on BPMP devices
> >   dt-bindings: sound: tegra: Update HDA resets
> >   arm64: tegra: Remove non existent Tegra194 reset
> 
> The change in HDA drier looks fine, and the question how to take those
> patches.  If other people can give acks, I can take those to sound.git
> tree destined for 5.16.
> 
> Or, if anyone else prefers taking those, feel free to do: for the
> first patch,
> 
> Reviewed-by: Takashi Iwai <[e-mail]>

My understanding is that patches 1-2 are mostly independent of patch 3,
with the latter being mostly a complementary cleanup. Patch 1 will
effectively ignore the non-existent reset on Tegra194 anyway. Patch 1
(and potentially 2) could go into v5.16 to fix the regression via
sound.git, but the cleanup in patch 3 isn't time-critical, so I could
just queue that up for v5.17 via the Tegra tree.

Sameer, any objections to that? Did I miss anything?

Thierry

Sameer Pujar Dec. 7, 2021, 8:47 a.m. UTC | #3

On 12/7/2021 1:51 PM, Thierry Reding wrote:
> On Tue, Dec 07, 2021 at 09:04:54AM +0100, Takashi Iwai wrote:
>> On Tue, 07 Dec 2021 07:32:47 +0100,
>> Sameer Pujar wrote:
>>> HDA probe failure is observed on Tegra194 based platforms and this
>>> happens due to a reset failure. The series fixes this problem by
>>> avoiding explicit resets on BPMP based devices.
>>>
>>> Sameer Pujar (3):
>>>    ALSA: hda/tegra: Skip reset on BPMP devices
>>>    dt-bindings: sound: tegra: Update HDA resets
>>>    arm64: tegra: Remove non existent Tegra194 reset
>> The change in HDA drier looks fine, and the question how to take those
>> patches.  If other people can give acks, I can take those to sound.git
>> tree destined for 5.16.
>>
>> Or, if anyone else prefers taking those, feel free to do: for the
>> first patch,
>>
>> Reviewed-by: Takashi Iwai<[e-mail]>
> My understanding is that patches 1-2 are mostly independent of patch 3,
> with the latter being mostly a complementary cleanup. Patch 1 will
> effectively ignore the non-existent reset on Tegra194 anyway. Patch 1
> (and potentially 2) could go into v5.16 to fix the regression via
> sound.git, but the cleanup in patch 3 isn't time-critical, so I could
> just queue that up for v5.17 via the Tegra tree.
>
> Sameer, any objections to that? Did I miss anything?

Yes, Patch 1 is critical to fix the regression. Remaining patches are 
for cleanup. So above plan sounds good to me.