| Message ID | 20181108073000.21114-1-peter.ujfalusi@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: omap-mcbsp: Cleanup and split core/sidetone support | expand |
On 11/8/18 9:29 AM, Peter Ujfalusi wrote: > Hi, > > Changes since v2: > - Split the dma_data addr and maxburst cleanup patches > - Added Jarkko's Acked-by tot he series. > Here's my promised testing too. I used a setup below to test sidetone functionality. Assuming both playback and recording path are already set. amixer -D hw:0 set 'McBSP2 Sidetone' on amixer -D hw:0 set 'McBSP2 Sidetone Channel 0' 100% amixer -D hw:0 set 'McBSP2 Sidetone Channel 1' 100% echo 32767 >/sys/devices/platform/68000000.ocp/49022000.mcbsp/st_taps echo threshold >/sys/devices/platform/68000000.ocp/49022000.mcbsp/dma_op_mode arecord -f dat >/dev/null |aplay -f dat /dev/zero ^^ arecord dumps into /dev/null and aplay plays from /dev/zero so only path from input to output is the sidetone path. Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
On 2018-11-10 17:59, Jarkko Nikula wrote: > On 11/8/18 9:29 AM, Peter Ujfalusi wrote: >> Hi, >> >> Changes since v2: >> - Split the dma_data addr and maxburst cleanup patches >> - Added Jarkko's Acked-by tot he series. >> > Here's my promised testing too. I used a setup below to test sidetone > functionality. Assuming both playback and recording path are already set. > > amixer -D hw:0 set 'McBSP2 Sidetone' on > amixer -D hw:0 set 'McBSP2 Sidetone Channel 0' 100% > amixer -D hw:0 set 'McBSP2 Sidetone Channel 1' 100% > echo 32767 >/sys/devices/platform/68000000.ocp/49022000.mcbsp/st_taps > echo threshold >> /sys/devices/platform/68000000.ocp/49022000.mcbsp/dma_op_mode > arecord -f dat >/dev/null |aplay -f dat /dev/zero > > ^^ > arecord dumps into /dev/null and aplay plays from /dev/zero so only path > from input to output is the sidetone path. > > Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com> Thanks Jarkko! - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Hi, Changes since v2: - Split the dma_data addr and maxburst cleanup patches - Added Jarkko's Acked-by tot he series. Changes since v1: - Two patch added to address the code move triggered few warnings from build. One of them is around mcbsp->pdata checks (not valid complaint), the other is that we set -EINVAL to unsigned variables (they were not used in that case) While preparing for merging the davinci and omap directories (I will send the series for that shortly) I have taken some time to do cleanup on the McBSP driver. The mcbsp.c/h files were the result when we moved code from arch/arm/plat-omap to sound/soc/omap/ a long time ago and it contained code for McBSP core and the OMAP3 sidetone functionality. With this series I tried to split the core and sidetone code to separate files. There were two reasons for this: 1. to have the OMAP specific DAI driver files prefixed with omap-* under the new sound/soc/ti/ directory 2. easier to find functions as all sidetone code is in separate file. Regards, Peter --- Peter Ujfalusi (8): ASoC: omap-mcbsp: Clean up dma_data addr initialization code ASoC: omap-mcbsp: Skip dma_data.maxburst initialization ASoC: omap-mcbsp: Clean up the interrupt handlers ASoC: omap-mcbsp: Simplify the mcbsp_start/_stop function parameters ASoC: omap-mcbsp: Move out the FIFO check from set_threshold and get_delay ASoC: omap-mcbsp: Re-arrange files for core McBSP and Sidetone function split ASoC: omap-mcbsp: Remove redundant check for mcbsp->pdata ASoC: omap-mcbsp: No need to initialize max_xx_thres when it is not used sound/soc/omap/Makefile | 2 +- sound/soc/omap/mcbsp.c | 1104 ----------------- sound/soc/omap/{mcbsp.h => omap-mcbsp-priv.h} | 126 +- sound/soc/omap/omap-mcbsp-st.c | 516 ++++++++ sound/soc/omap/omap-mcbsp.c | 852 ++++++++++--- sound/soc/omap/omap-mcbsp.h | 8 +- 6 files changed, 1278 insertions(+), 1330 deletions(-) delete mode 100644 sound/soc/omap/mcbsp.c rename sound/soc/omap/{mcbsp.h => omap-mcbsp-priv.h} (70%) create mode 100644 sound/soc/omap/omap-mcbsp-st.c