mbox series

[0/6] ALSA: firewire: fix wrong reference count for stream functionality at error path of rawmidi interface

Message ID 20190707052011.24687-1-o-takashi@sakamocchi.jp (mailing list archive)
Headers show
Series ALSA: firewire: fix wrong reference count for stream functionality at error path of rawmidi interface | expand

Message

Takashi Sakamoto July 7, 2019, 5:20 a.m. UTC
Hi,

All of drivers in ALSA firewire stack maintain packet streaming by
reference count. However at error path of MIDI interface, some
drivers have a bug that the count remains at error path of rawmidi
interface. This causes the drivers don't stop packet streaming even
if it's not required.

This patchset fixes drivers including the bug.

Takashi Sakamoto (6):
  ALSA: bebob: fix wrong reference count for stream functionality at
    error path of rawmidi interface
  ALSA: fireworks: fix wrong reference count for stream functionality at
    error path of rawmidi interface
  ALSA: oxfw: fix wrong reference count for stream functionality at
    error path of rawmidi interface
  ALSA: dice: fix wrong reference count for stream functionality at
    error path of rawmidi interface
  ALSA: firewire-digi00x: fix wrong reference count for stream
    functionality at error path of rawmidi interface
  firewire-motu: fix wrong reference count for stream functionality at
    error path of rawmidi interface

 sound/firewire/bebob/bebob_midi.c         | 2 ++
 sound/firewire/dice/dice-midi.c           | 2 ++
 sound/firewire/digi00x/digi00x-midi.c     | 2 ++
 sound/firewire/fireworks/fireworks_midi.c | 2 ++
 sound/firewire/motu/motu-midi.c           | 2 ++
 sound/firewire/oxfw/oxfw-midi.c           | 2 ++
 6 files changed, 12 insertions(+)

Comments

Takashi Iwai July 7, 2019, 9:20 a.m. UTC | #1
On Sun, 07 Jul 2019 07:20:05 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> All of drivers in ALSA firewire stack maintain packet streaming by
> reference count. However at error path of MIDI interface, some
> drivers have a bug that the count remains at error path of rawmidi
> interface. This causes the drivers don't stop packet streaming even
> if it's not required.
> 
> This patchset fixes drivers including the bug.
> 
> Takashi Sakamoto (6):
>   ALSA: bebob: fix wrong reference count for stream functionality at
>     error path of rawmidi interface
>   ALSA: fireworks: fix wrong reference count for stream functionality at
>     error path of rawmidi interface
>   ALSA: oxfw: fix wrong reference count for stream functionality at
>     error path of rawmidi interface
>   ALSA: dice: fix wrong reference count for stream functionality at
>     error path of rawmidi interface
>   ALSA: firewire-digi00x: fix wrong reference count for stream
>     functionality at error path of rawmidi interface
>   firewire-motu: fix wrong reference count for stream functionality at
>     error path of rawmidi interface

Applied all six patches now.  Thanks.


Takashi