From patchwork Fri Aug 30 10:38:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Ujfalusi X-Patchwork-Id: 11123719 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CE9F01398 for ; Fri, 30 Aug 2019 10:39:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D66AB2073F for ; Fri, 30 Aug 2019 10:39:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="vJqkXHB4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pXqaVVy/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D66AB2073F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A7F51829; Fri, 30 Aug 2019 12:38:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A7F51829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1567161558; bh=Lxs7tqO7n+gd0FFCOr981CHPasNEeORIiAycp81apQ4=; h=From:To:Date:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=vJqkXHB4QwbJqRQIcDeuSuV+zwdX4D7Y//Gzv4pz6a6ZmuY6mRg9mgmWqiFauGhee SR9EEVaX7U3qJm6hDi5ZDs60TbFepn1aneXjAz25DvYqm4HdxqLKXXMLp2D5itTktw FIxJDUAYOq+3eBkLHBIsbhoY9rtfm4f9B/GVHels= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2491CF8036C; Fri, 30 Aug 2019 12:38:28 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa1.perex.cz (Postfix, from userid 50401) id DF8E6F8036C; Fri, 30 Aug 2019 12:38:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on alsa1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,PRX_BODY_78,SPF_HELO_NONE,SPF_PASS autolearn=disabled version=3.4.0 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id EBD0DF800E7 for ; Fri, 30 Aug 2019 12:38:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz EBD0DF800E7 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="pXqaVVy/" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x7UAcJc8121857; Fri, 30 Aug 2019 05:38:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1567161499; bh=PEtyBDRVuUg45ipLY+S+ZuxpDuvqx/qkDHeAS3yV02c=; h=From:To:CC:Subject:Date; b=pXqaVVy/T0z+TeIM+9MtNnb8Hj2EzHaIwzDBqK7e1K4fs4l1xP9LkcA/QBC5nz5TY FcRtIMUyEXJIP9UNldzpnfcr0YTuQCmMZEGBTf28eExXHEeqHEwaTqxLlvy8Sucf8f kmhjU8e3UnMIWrsQHoW37zZalEblPt5ioHgcrtgw= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x7UAcJip019540 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 30 Aug 2019 05:38:19 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 30 Aug 2019 05:38:18 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 30 Aug 2019 05:38:18 -0500 Received: from feketebors.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x7UAcG3Y076275; Fri, 30 Aug 2019 05:38:17 -0500 From: Peter Ujfalusi To: , Date: Fri, 30 Aug 2019 13:38:37 +0300 Message-ID: <20190830103841.25128-1-peter.ujfalusi@ti.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: alsa-devel@alsa-project.org, nsekhar@ti.com, kuninori.morimoto.gx@renesas.com Subject: [alsa-devel] [PATCH 0/4] ASoC: ti: davinci: Fixes for daVinci boards with McBSP X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, Morimoto-san pointed out in a private thread that the davinci-i2s driver is using snd_soc_rtdcom_lookup(), which is should not really. It took a while to get access to a daVinci board which uses McBSP, but eventually I got access to a remote dm644x-evm and dma365-evm. Initially the audio was not even probing on them (fixes sent for mach-davinci), but then the driver was still crashing and not behaving correctly. With the 4 patch dm644x-evm have working audio and the offending snd_soc_rtdcom_lookup() is gone from the driver. dm365-evm still have some issues regarding to EDMA, but it looks like a system issue which can be fixed later. Regards, Peter --- Peter Ujfalusi (4): ASoC: ti: davinci-i2s: Add S32_LE as support format ASoC: ti: davinci-i2s: Move the XSYNCERR workaround to .prepare callback ASoC: ti: edma-pcm: Fix for legacy dma_slave_map based channel lookup ASoC: ti: davinci-evm: Do not fail if the dai_set_sysclk returns -ENOTSUPP sound/soc/ti/davinci-evm.c | 2 +- sound/soc/ti/davinci-i2s.c | 90 +++++++++++++++++--------------------- sound/soc/ti/edma-pcm.c | 17 ++++++- 3 files changed, 57 insertions(+), 52 deletions(-)