| Message ID | 20200305134404.7690-1-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | ucm2: Add support to SDM845 based platforms | expand |
Hi Jaroslav, On 05/03/2020 13:44, Srinivas Kandagatla wrote: > This patchset adds UCM support for WSA881x, WCD934x codec and two platforms, > DB845c DragonBoard and Lenovo YOGA C360 Laptop that use these codecs. > > Tested on Ubuntu 20.04 with pulseaudio 13 along with > with this fix > https://github.com/pulseaudio/pulseaudio/commit/cabd387e26b5fe03661f4b894826c7c6b58d7efa > Are you okay to pick these ucm2 patches? thanks, srini > Thanks, > srini > > Srinivas Kandagatla (4): > ucm2: codecs: wcd934x: Add Codec sequences. > ucm2: codecs: wsa881x: add codec sequences > ucm2: DB845c: Add ucm for DB845c board > ucm2: Add ucm for Lenovo-YOGA-C630-13Q50 laptop > > ucm2/DB845c/DB845c.conf | 11 +++ > ucm2/DB845c/HDMI.conf | 33 +++++++ > ucm2/DB845c/HiFi.conf | 46 +++++++++ > ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf | 98 +++++++++++++++++++ > .../Lenovo-YOGA-C630-13Q50.conf | 6 ++ > ucm2/codecs/wcd934x/DefaultDisableSeq.conf | 5 + > ucm2/codecs/wcd934x/DefaultEnableSeq.conf | 14 +++ > ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf | 6 ++ > ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf | 6 ++ > .../wcd934x/HeadphoneMicDisableSeq.conf | 2 + > .../codecs/wcd934x/HeadphoneMicEnableSeq.conf | 3 + > ucm2/codecs/wcd934x/SpeakerDisableSeq.conf | 4 + > ucm2/codecs/wcd934x/SpeakerEnableSeq.conf | 4 + > ucm2/codecs/wsa881x/DefaultEnableSeq.conf | 8 ++ > ucm2/codecs/wsa881x/SpeakerDisableSeq.conf | 8 ++ > ucm2/codecs/wsa881x/SpeakerEnableSeq.conf | 8 ++ > 16 files changed, 262 insertions(+) > create mode 100644 ucm2/DB845c/DB845c.conf > create mode 100644 ucm2/DB845c/HDMI.conf > create mode 100644 ucm2/DB845c/HiFi.conf > create mode 100644 ucm2/Lenovo-YOGA-C630-13Q50/HiFi.conf > create mode 100644 ucm2/Lenovo-YOGA-C630-13Q50/Lenovo-YOGA-C630-13Q50.conf > create mode 100644 ucm2/codecs/wcd934x/DefaultDisableSeq.conf > create mode 100644 ucm2/codecs/wcd934x/DefaultEnableSeq.conf > create mode 100644 ucm2/codecs/wcd934x/HeadphoneDisableSeq.conf > create mode 100644 ucm2/codecs/wcd934x/HeadphoneEnableSeq.conf > create mode 100644 ucm2/codecs/wcd934x/HeadphoneMicDisableSeq.conf > create mode 100644 ucm2/codecs/wcd934x/HeadphoneMicEnableSeq.conf > create mode 100644 ucm2/codecs/wcd934x/SpeakerDisableSeq.conf > create mode 100644 ucm2/codecs/wcd934x/SpeakerEnableSeq.conf > create mode 100644 ucm2/codecs/wsa881x/DefaultEnableSeq.conf > create mode 100644 ucm2/codecs/wsa881x/SpeakerDisableSeq.conf > create mode 100644 ucm2/codecs/wsa881x/SpeakerEnableSeq.conf >
Dne 30. 03. 20 v 16:10 Srinivas Kandagatla napsal(a): > Hi Jaroslav, > > On 05/03/2020 13:44, Srinivas Kandagatla wrote: >> This patchset adds UCM support for WSA881x, WCD934x codec and two platforms, >> DB845c DragonBoard and Lenovo YOGA C360 Laptop that use these codecs. >> >> Tested on Ubuntu 20.04 with pulseaudio 13 along with >> with this fix >> https://github.com/pulseaudio/pulseaudio/commit/cabd387e26b5fe03661f4b894826c7c6b58d7efa >> > > Are you okay to pick these ucm2 patches? Hi, it seems that those changes does not pass through the ucm validator (https://github.com/alsa-project/alsa-tests - python/ucm-validator directory). I have also some comments, but I would probably prefer to create a pull request on github to do the review for all files with history. Thank you, Jaroslav
On 30/03/2020 15:19, Jaroslav Kysela wrote: > Dne 30. 03. 20 v 16:10 Srinivas Kandagatla napsal(a): >> Hi Jaroslav, >> >> On 05/03/2020 13:44, Srinivas Kandagatla wrote: >>> This patchset adds UCM support for WSA881x, WCD934x codec and two >>> platforms, >>> DB845c DragonBoard and Lenovo YOGA C360 Laptop that use these codecs. >>> >>> Tested on Ubuntu 20.04 with pulseaudio 13 along with >>> with this fix >>> >>> https://github.com/pulseaudio/pulseaudio/commit/cabd387e26b5fe03661f4b894826c7c6b58d7efa >>> >>> >> >> Are you okay to pick these ucm2 patches? > > Hi, > > it seems that those changes does not pass through the ucm validator > (https://github.com/alsa-project/alsa-tests - python/ucm-validator > directory). Thanks, I did not knew that there was an ucm-validator, I try run it and fix those issues before sending a pull request! --srini > > I have also some comments, but I would probably prefer to create a > pull request on github to do the review for all files with history. > > Thank you, > Jaroslav