| Message ID | 20200903114504.1202143-1-vkoul@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | soundwire: use FIELD_{GET|PREP} in subsystem | expand |
On 9/3/2020 7:44 PM, Vinod Koul wrote: > Use the FIELD_{GET|PREP} in soundwire subsytem and remove the local > SDW_REG_SHIFT(). This makes code IMO look much neater > > Tested this on db845c board > > Changes in v2: > - fold in fixes provided by Bard and Pierre > - Use GENMAS_ULL for addr > - rebase to next and fold in new intel change > > Vinod Koul (9): > soundwire: define and use addr bit masks > soundwire: bus: use FIELD_GET() > soundwire: slave: use SDW_DISCO_LINK_ID() > soundwire: stream: use FIELD_{GET|PREP} > soundwire: qcom : use FIELD_{GET|PREP} > soundwire: cadence: use FIELD_{GET|PREP} > soundwire: intel: use FIELD_{GET|PREP} > soundwire: intel_init: use FIELD_{GET|PREP} > soundwire: remove SDW_REG_SHIFT() > > drivers/soundwire/bus.c | 6 +-- > drivers/soundwire/cadence_master.c | 61 +++++++++++-------------- > drivers/soundwire/intel.c | 52 ++++++++------------- > drivers/soundwire/intel_init.c | 2 +- > drivers/soundwire/qcom.c | 22 +++------ > drivers/soundwire/slave.c | 2 +- > drivers/soundwire/stream.c | 13 ++---- > include/linux/soundwire/sdw.h | 21 ++++++--- > include/linux/soundwire/sdw_registers.h | 7 --- > 9 files changed, 75 insertions(+), 111 deletions(-) Tested it on Intel platforms. Tested-by: Bard Liao <yung-chuan.liao@linux.intel.com>
On 04-09-20, 15:46, Bard liao wrote: > > On 9/3/2020 7:44 PM, Vinod Koul wrote: > > Use the FIELD_{GET|PREP} in soundwire subsytem and remove the local > > SDW_REG_SHIFT(). This makes code IMO look much neater > > > > Tested this on db845c board > > > > Changes in v2: > > - fold in fixes provided by Bard and Pierre > > - Use GENMAS_ULL for addr > > - rebase to next and fold in new intel change > > > > Vinod Koul (9): > > soundwire: define and use addr bit masks > > soundwire: bus: use FIELD_GET() > > soundwire: slave: use SDW_DISCO_LINK_ID() > > soundwire: stream: use FIELD_{GET|PREP} > > soundwire: qcom : use FIELD_{GET|PREP} > > soundwire: cadence: use FIELD_{GET|PREP} > > soundwire: intel: use FIELD_{GET|PREP} > > soundwire: intel_init: use FIELD_{GET|PREP} > > soundwire: remove SDW_REG_SHIFT() > > > > drivers/soundwire/bus.c | 6 +-- > > drivers/soundwire/cadence_master.c | 61 +++++++++++-------------- > > drivers/soundwire/intel.c | 52 ++++++++------------- > > drivers/soundwire/intel_init.c | 2 +- > > drivers/soundwire/qcom.c | 22 +++------ > > drivers/soundwire/slave.c | 2 +- > > drivers/soundwire/stream.c | 13 ++---- > > include/linux/soundwire/sdw.h | 21 ++++++--- > > include/linux/soundwire/sdw_registers.h | 7 --- > > 9 files changed, 75 insertions(+), 111 deletions(-) > > Tested it on Intel platforms. > > Tested-by: Bard Liao <yung-chuan.liao@linux.intel.com> Thanks Bard, applied now
Use the FIELD_{GET|PREP} in soundwire subsytem and remove the local SDW_REG_SHIFT(). This makes code IMO look much neater Tested this on db845c board Changes in v2: - fold in fixes provided by Bard and Pierre - Use GENMAS_ULL for addr - rebase to next and fold in new intel change Vinod Koul (9): soundwire: define and use addr bit masks soundwire: bus: use FIELD_GET() soundwire: slave: use SDW_DISCO_LINK_ID() soundwire: stream: use FIELD_{GET|PREP} soundwire: qcom : use FIELD_{GET|PREP} soundwire: cadence: use FIELD_{GET|PREP} soundwire: intel: use FIELD_{GET|PREP} soundwire: intel_init: use FIELD_{GET|PREP} soundwire: remove SDW_REG_SHIFT() drivers/soundwire/bus.c | 6 +-- drivers/soundwire/cadence_master.c | 61 +++++++++++-------------- drivers/soundwire/intel.c | 52 ++++++++------------- drivers/soundwire/intel_init.c | 2 +- drivers/soundwire/qcom.c | 22 +++------ drivers/soundwire/slave.c | 2 +- drivers/soundwire/stream.c | 13 ++---- include/linux/soundwire/sdw.h | 21 ++++++--- include/linux/soundwire/sdw_registers.h | 7 --- 9 files changed, 75 insertions(+), 111 deletions(-)