[v2,0/6] soundwire/ASoC: abstract platform-dependent bases

Message

Bard Liao July 23, 2021, 11:54 a.m. UTC

shim base and alh base are platform-dependent. This series suggests
to use variables for those bases. It allows us to use different bases
for new platforms.

v2:
 - Update the commit message of "soundwire: move intel sdw register
   definitions to sdw_intel.h"

Bard Liao (6):
  soundwire: move intel sdw register definitions to sdw_intel.h
  ASoC: SOF: intel: add sdw_shim/alh_base to sof_intel_dsp_desc
  ASoC: SOF: intel: hda: remove HDA_DSP_REG_SNDW_WAKE_STS definition
  ASoC: SOF: intel: move sof_intel_dsp_desc() forward
  ASoC: SOF: intel: add snd_sof_dsp_check_sdw_irq ops
  soundwire: intel: introduce shim and alh base

 drivers/soundwire/intel.c           | 74 ------------------------
 drivers/soundwire/intel_init.c      | 14 ++---
 include/linux/soundwire/sdw_intel.h | 87 +++++++++++++++++++++++++++++
 sound/soc/sof/intel/cnl.c           |  6 ++
 sound/soc/sof/intel/hda.c           | 39 ++++++++-----
 sound/soc/sof/intel/hda.h           |  8 ++-
 sound/soc/sof/intel/icl.c           |  3 +
 sound/soc/sof/intel/shim.h          |  3 +
 sound/soc/sof/intel/tgl.c           | 12 ++++
 9 files changed, 149 insertions(+), 97 deletions(-)

Comments

Mark Brown July 27, 2021, 4:11 p.m. UTC | #1

On Fri, Jul 23, 2021 at 07:54:45PM +0800, Bard Liao wrote:
> shim base and alh base are platform-dependent. This series suggests
> to use variables for those bases. It allows us to use different bases
> for new platforms.

The ASoC bits look fine to me, what't eh plan for merging this?  I can
apply to ASoC if people like, or should the Soundwire bits go via the
Soundwire tree?

Liao, Bard July 28, 2021, 12:38 a.m. UTC | #2

> -----Original Message-----
> From: Mark Brown <[e-mail]>
> Sent: Wednesday, July 28, 2021 12:12 AM
> To: Bard Liao <[e-mail]>
> Cc: [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; [e-mail];
> [e-mail]; [e-mail]; Kale,
> Sanyog R <[e-mail]>; Liao, Bard <[e-mail]>
> Subject: Re: [PATCH v2 0/6] soundwire/ASoC: abstract platform-dependent
> bases
> 
> On Fri, Jul 23, 2021 at 07:54:45PM +0800, Bard Liao wrote:
> > shim base and alh base are platform-dependent. This series suggests to
> > use variables for those bases. It allows us to use different bases for
> > new platforms.
> 
> The ASoC bits look fine to me, what't eh plan for merging this?  I can apply to
> ASoC if people like, or should the Soundwire bits go via the Soundwire tree?

Thanks Mark. Apply to ASoC or Soundwire are both fine to me.

Vinod Koul Aug. 2, 2021, 4:37 a.m. UTC | #3

On 28-07-21, 00:38, Liao, Bard wrote:
> > -----Original Message-----
> > From: Mark Brown <[e-mail]>
> > Sent: Wednesday, July 28, 2021 12:12 AM
> > To: Bard Liao <[e-mail]>
> > Cc: [e-mail]; [e-mail]; [e-mail];
> > [e-mail]; [e-mail]; [e-mail];
> > [e-mail]; [e-mail]; Kale,
> > Sanyog R <[e-mail]>; Liao, Bard <[e-mail]>
> > Subject: Re: [PATCH v2 0/6] soundwire/ASoC: abstract platform-dependent
> > bases
> > 
> > On Fri, Jul 23, 2021 at 07:54:45PM +0800, Bard Liao wrote:
> > > shim base and alh base are platform-dependent. This series suggests to
> > > use variables for those bases. It allows us to use different bases for
> > > new platforms.
> > 
> > The ASoC bits look fine to me, what't eh plan for merging this?  I can apply to
> > ASoC if people like, or should the Soundwire bits go via the Soundwire tree?

I have acked the sdw parts, pls pick them thru ASoC tree. If we have
conflicts, I can merge the immutable tag from your tree.

> Thanks Mark. Apply to ASoC or Soundwire are both fine to me.

Mark Brown Aug. 2, 2021, 8:44 p.m. UTC | #4

On Fri, 23 Jul 2021 19:54:45 +0800, Bard Liao wrote:
> shim base and alh base are platform-dependent. This series suggests
> to use variables for those bases. It allows us to use different bases
> for new platforms.
> 
> v2:
>  - Update the commit message of "soundwire: move intel sdw register
>    definitions to sdw_intel.h"
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/6] soundwire: move intel sdw register definitions to sdw_intel.h
      commit: f01639589e252a6f72c04716e1b5f9bb10e2debc
[2/6] ASoC: SOF: intel: add sdw_shim/alh_base to sof_intel_dsp_desc
      commit: 1cbf6443f0de6489044909b35962ba71940d48fe
[3/6] ASoC: SOF: intel: hda: remove HDA_DSP_REG_SNDW_WAKE_STS definition
      commit: 781dd3c822683f4b5dc332b68ac49d2db3d400e9
[4/6] ASoC: SOF: intel: move sof_intel_dsp_desc() forward
      commit: 2f1315ae94b46bf0d5b4be29be15cc3641364404
[5/6] ASoC: SOF: intel: add snd_sof_dsp_check_sdw_irq ops
      commit: 198fa4bcf6a1e8685b43e37790d45f3ebcbc2784
[6/6] soundwire: intel: introduce shim and alh base
      commit: 60e9feb781dfe84158b4ec7a4d61c5103e96e6f3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark