mbox series

[v1,0/2] kselftest: alsa: Small enhancements to mixer-test

Message ID 20211217130213.3893415-1-broonie@kernel.org (mailing list archive)
Headers show
Series kselftest: alsa: Small enhancements to mixer-test | expand

Message

Mark Brown Dec. 17, 2021, 1:02 p.m. UTC 
These two patches improve the mixer test, checking that the default
values for enums are valid and extending them to cover all the values
for multi-value controls, not just the first one.  It also factors out
the validation that values are OK for controls for future reuse.

Mark Brown (2):
  kselftest: alsa: Factor out check that values meet constraints
  kselftest: alsa: Validate values read from enumerations

 tools/testing/selftests/alsa/mixer-test.c | 158 ++++++++++++++--------
 1 file changed, 99 insertions(+), 59 deletions(-)


base-commit: b73dad806533cad55df41a9c0349969b56d4ff7f

Comments

Cezary Rojewski Dec. 17, 2021, 3:01 p.m. UTC | #1 
On 2021-12-17 2:02 PM, Mark Brown wrote:
> These two patches improve the mixer test, checking that the default
> values for enums are valid and extending them to cover all the values
> for multi-value controls, not just the first one.  It also factors out
> the validation that values are OK for controls for future reuse.
> 
> Mark Brown (2):
>    kselftest: alsa: Factor out check that values meet constraints
>    kselftest: alsa: Validate values read from enumerations
> 
>   tools/testing/selftests/alsa/mixer-test.c | 158 ++++++++++++++--------
>   1 file changed, 99 insertions(+), 59 deletions(-)
> 
> 
> base-commit: b73dad806533cad55df41a9c0349969b56d4ff7f
> 

Apart from my previous question regarding patch 1/2 (which has been 
already answered), I have not found any issues with the series.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>


Regards,
Czarek
Takashi Iwai Dec. 25, 2021, 8:13 a.m. UTC | #2 
On Fri, 17 Dec 2021 14:02:11 +0100,
Mark Brown wrote:
> 
> These two patches improve the mixer test, checking that the default
> values for enums are valid and extending them to cover all the values
> for multi-value controls, not just the first one.  It also factors out
> the validation that values are OK for controls for future reuse.
> 
> Mark Brown (2):
>   kselftest: alsa: Factor out check that values meet constraints
>   kselftest: alsa: Validate values read from enumerations

Applied both patches now.  Thanks.


Takashi