| Message ID | 20220121172431.6876-1-sbinding@opensource.cirrus.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Support Spi in i2c-multi-instantiate driver | expand |
Hi Stefan, On 1/21/22 18:24, Stefan Binding wrote: > Add support for SPI bus in the i2c-multi-instantiate driver as > upcoming laptops will need to multi instantiate SPI devices from > a single device node, which has multiple SpiSerialBus entries at > the ACPI table. > > With the new SPI support, i2c-multi-instantiate becomes > bus-multi-instantiate and is moved to the ACPI folder. > > The intention is to support the SPI bus by re-using the current > I2C multi instantiate, instead of creating a new SPI multi > instantiate, to make it possible for peripherals that can be > controlled by I2C or SPI to have the same HID at the ACPI table. > > The new driver (serial multi instantiate, smi) checks for the > hard-coded bus type and returns -ENODEV in case of zero devices > found for that bus. In the case of automatic bus detection, > the driver will give preference to I2C. > > The expectation is for a device node in the ACPI table to have > multiple I2cSerialBus only or multiple SpiSerialBus only, not > a mix of both; and for the case where there are both entries in > one device node, only the I2C ones would be probed. > > This new serial multi instantiate will be used in CS35L41 HDA new > driver. > > Changes since V5: > - comment, commit message and Kconfig description fixes > - minor fixes in serial-multi-instantiate > - use lowercase for SSIDs in patch_realtek.c Thank you for the new versions. I gave a bunch of: Reviewed-by: Hans de Goede <hdegoede@redhat.com> tags for v4, unless you make big changes, you are supposed to collect this tag and add it to newer versions of the patch-set (just above your own S-o-b). I'll resend the Reviewed-by-s for this version, please collect them for the next version (I noticed there are still some small issues, sorry). Regards, Hans > > Lucas Tanure (4): > platform/x86: i2c-multi-instantiate: Rename it for a generic serial > driver name > platform/x86: serial-multi-instantiate: Reorganize I2C functions > ALSA: hda/realtek: Add support for HP Laptops > ACPI / scan: Create platform device for CS35L41 > > Stefan Binding (5): > spi: Make spi_alloc_device and spi_add_device public again > spi: Create helper API to lookup ACPI info for spi device > spi: Support selection of the index of the ACPI Spi Resource before > alloc > spi: Add API to count spi acpi resources > platform/x86: serial-multi-instantiate: Add SPI support > > MAINTAINERS | 4 +- > drivers/acpi/scan.c | 16 +- > drivers/platform/x86/Kconfig | 12 +- > drivers/platform/x86/Makefile | 2 +- > drivers/platform/x86/i2c-multi-instantiate.c | 174 --------- > .../platform/x86/serial-multi-instantiate.c | 349 ++++++++++++++++++ > drivers/spi/spi.c | 137 ++++++- > include/linux/spi/spi.h | 20 + > sound/pci/hda/patch_realtek.c | 43 ++- > 9 files changed, 551 insertions(+), 206 deletions(-) > delete mode 100644 drivers/platform/x86/i2c-multi-instantiate.c > create mode 100644 drivers/platform/x86/serial-multi-instantiate.c >
On Fri, 21 Jan 2022 17:24:22 +0000, Stefan Binding wrote: > Add support for SPI bus in the i2c-multi-instantiate driver as > upcoming laptops will need to multi instantiate SPI devices from > a single device node, which has multiple SpiSerialBus entries at > the ACPI table. > > With the new SPI support, i2c-multi-instantiate becomes > bus-multi-instantiate and is moved to the ACPI folder. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/9] spi: Make spi_alloc_device and spi_add_device public again commit: 941bffd7d7f5d6030a54184c5d81b0eb9116ca9a [2/9] spi: Create helper API to lookup ACPI info for spi device commit: 70dd264bc07aee4f89e65138db11e908701388dd [3/9] spi: Support selection of the index of the ACPI Spi Resource before alloc commit: 92640f98a78c6a3ea1ca32143144241eceb129bd [4/9] spi: Add API to count spi acpi resources commit: 113962301d2d9a5c11381d9c25ddea7af71be2ff All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
On Fri, Jan 21, 2022 at 05:24:22PM +0000, Stefan Binding wrote: > Add support for SPI bus in the i2c-multi-instantiate driver as > upcoming laptops will need to multi instantiate SPI devices from > a single device node, which has multiple SpiSerialBus entries at > the ACPI table. The following changes since commit e783362eb54cd99b2cac8b3a9aeac942e6f6ac07: Linux 5.17-rc1 (2022-01-23 10:12:53 +0200) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git tags/spi-acpi-helpers for you to fetch changes up to e612af7acef2459f1afd885f4107748995a05963: spi: Add API to count spi acpi resources (2022-02-01 17:38:48 +0000) ---------------------------------------------------------------- spi: ACPI helpers This patch series enhances the ACPI helpers to cope with multiple resources being available and exports them for use. ---------------------------------------------------------------- Stefan Binding (4): spi: Make spi_alloc_device and spi_add_device public again spi: Create helper API to lookup ACPI info for spi device spi: Support selection of the index of the ACPI Spi Resource before alloc spi: Add API to count spi acpi resources drivers/spi/spi.c | 137 ++++++++++++++++++++++++++++++++++++++++++------ include/linux/spi/spi.h | 20 +++++++ 2 files changed, 141 insertions(+), 16 deletions(-)
Add support for SPI bus in the i2c-multi-instantiate driver as upcoming laptops will need to multi instantiate SPI devices from a single device node, which has multiple SpiSerialBus entries at the ACPI table. With the new SPI support, i2c-multi-instantiate becomes bus-multi-instantiate and is moved to the ACPI folder. The intention is to support the SPI bus by re-using the current I2C multi instantiate, instead of creating a new SPI multi instantiate, to make it possible for peripherals that can be controlled by I2C or SPI to have the same HID at the ACPI table. The new driver (serial multi instantiate, smi) checks for the hard-coded bus type and returns -ENODEV in case of zero devices found for that bus. In the case of automatic bus detection, the driver will give preference to I2C. The expectation is for a device node in the ACPI table to have multiple I2cSerialBus only or multiple SpiSerialBus only, not a mix of both; and for the case where there are both entries in one device node, only the I2C ones would be probed. This new serial multi instantiate will be used in CS35L41 HDA new driver. Changes since V5: - comment, commit message and Kconfig description fixes - minor fixes in serial-multi-instantiate - use lowercase for SSIDs in patch_realtek.c Lucas Tanure (4): platform/x86: i2c-multi-instantiate: Rename it for a generic serial driver name platform/x86: serial-multi-instantiate: Reorganize I2C functions ALSA: hda/realtek: Add support for HP Laptops ACPI / scan: Create platform device for CS35L41 Stefan Binding (5): spi: Make spi_alloc_device and spi_add_device public again spi: Create helper API to lookup ACPI info for spi device spi: Support selection of the index of the ACPI Spi Resource before alloc spi: Add API to count spi acpi resources platform/x86: serial-multi-instantiate: Add SPI support MAINTAINERS | 4 +- drivers/acpi/scan.c | 16 +- drivers/platform/x86/Kconfig | 12 +- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/i2c-multi-instantiate.c | 174 --------- .../platform/x86/serial-multi-instantiate.c | 349 ++++++++++++++++++ drivers/spi/spi.c | 137 ++++++- include/linux/spi/spi.h | 20 + sound/pci/hda/patch_realtek.c | 43 ++- 9 files changed, 551 insertions(+), 206 deletions(-) delete mode 100644 drivers/platform/x86/i2c-multi-instantiate.c create mode 100644 drivers/platform/x86/serial-multi-instantiate.c