mbox series

[v2,0/6] Add Tegra234 HDA support

Message ID 20220210065057.13555-1-mkumard@nvidia.com (mailing list archive)
Headers show
Series Add Tegra234 HDA support | expand

Message

Mohan Kumar D Feb. 10, 2022, 6:50 a.m. UTC
This series add the support for TEGRA234 HDA driver support

Mohan Kumar (6):
  ALSA: hda/tegra: Add Tegra234 hda driver support
  ALSA: hda/tegra: Hardcode GCAP ISS value on T234
  ALSA: hda/tegra: Update scratch reg. communication
  dt-bindings: Add HDA support for Tegra234
  dt-bindings: Document Tegra234 HDA support
  arm64: tegra: Add hda dts node for Tegra234

 .../bindings/sound/nvidia,tegra30-hda.yaml    |   3 +
 .../nvidia/tegra234-p3737-0000+p3701-0000.dts |   6 +
 arch/arm64/boot/dts/nvidia/tegra234.dtsi      |  18 +++
 include/dt-bindings/clock/tegra234-clock.h    |   4 +
 include/dt-bindings/memory/tegra234-mc.h      |   6 +
 .../dt-bindings/power/tegra234-powergate.h    |   9 ++
 include/dt-bindings/reset/tegra234-reset.h    |   2 +
 sound/pci/hda/hda_tegra.c                     |  33 ++++-
 sound/pci/hda/patch_hdmi.c                    | 118 ++++++++++++++----
 9 files changed, 175 insertions(+), 24 deletions(-)
 create mode 100644 include/dt-bindings/power/tegra234-powergate.h

Comments

Takashi Iwai Feb. 15, 2022, 1:29 p.m. UTC | #1
On Thu, 10 Feb 2022 07:50:51 +0100,
Mohan Kumar wrote:
> 
> This series add the support for TEGRA234 HDA driver support
> 
> Mohan Kumar (6):
>   ALSA: hda/tegra: Add Tegra234 hda driver support
>   ALSA: hda/tegra: Hardcode GCAP ISS value on T234
>   ALSA: hda/tegra: Update scratch reg. communication
>   dt-bindings: Add HDA support for Tegra234
>   dt-bindings: Document Tegra234 HDA support
>   arm64: tegra: Add hda dts node for Tegra234

Applied all six patches to for-next branch now.


thanks,

Takashi
Takashi Iwai Feb. 15, 2022, 1:34 p.m. UTC | #2
On Tue, 15 Feb 2022 14:29:54 +0100,
Takashi Iwai wrote:
> 
> On Thu, 10 Feb 2022 07:50:51 +0100,
> Mohan Kumar wrote:
> > 
> > This series add the support for TEGRA234 HDA driver support
> > 
> > Mohan Kumar (6):
> >   ALSA: hda/tegra: Add Tegra234 hda driver support
> >   ALSA: hda/tegra: Hardcode GCAP ISS value on T234
> >   ALSA: hda/tegra: Update scratch reg. communication
> >   dt-bindings: Add HDA support for Tegra234
> >   dt-bindings: Document Tegra234 HDA support
> >   arm64: tegra: Add hda dts node for Tegra234
> 
> Applied all six patches to for-next branch now.

... and now I realized that it's conflicting with the latest Tegra234
reset stuff on linux-next.

Maybe better to split the patches to be merged through several trees?


Takashi
Mohan Kumar D Feb. 16, 2022, 7:31 a.m. UTC | #3
Ok, Let me resync linux-next to clear the conflict and will resend patches with v3.

-----Original Message-----
From: Takashi Iwai <tiwai@suse.de> 
Sent: Tuesday, February 15, 2022 7:04 PM
To: Mohan Kumar D <mkumard@nvidia.com>
Cc: broonie@kernel.org; lgirdwood@gmail.com; robh+dt@kernel.org; thierry.reding@gmail.com; tiwai@suse.com; Jonathan Hunter <jonathanh@nvidia.com>; Sameer Pujar <spujar@nvidia.com>; alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux-tegra@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/6] Add Tegra234 HDA support

External email: Use caution opening links or attachments


On Tue, 15 Feb 2022 14:29:54 +0100,
Takashi Iwai wrote:
>
> On Thu, 10 Feb 2022 07:50:51 +0100,
> Mohan Kumar wrote:
> >
> > This series add the support for TEGRA234 HDA driver support
> >
> > Mohan Kumar (6):
> >   ALSA: hda/tegra: Add Tegra234 hda driver support
> >   ALSA: hda/tegra: Hardcode GCAP ISS value on T234
> >   ALSA: hda/tegra: Update scratch reg. communication
> >   dt-bindings: Add HDA support for Tegra234
> >   dt-bindings: Document Tegra234 HDA support
> >   arm64: tegra: Add hda dts node for Tegra234
>
> Applied all six patches to for-next branch now.

... and now I realized that it's conflicting with the latest Tegra234 reset stuff on linux-next.

Maybe better to split the patches to be merged through several trees?


Takashi
Thierry Reding Feb. 16, 2022, 2:23 p.m. UTC | #4
On Tue, Feb 15, 2022 at 02:34:01PM +0100, Takashi Iwai wrote:
> On Tue, 15 Feb 2022 14:29:54 +0100,
> Takashi Iwai wrote:
> > 
> > On Thu, 10 Feb 2022 07:50:51 +0100,
> > Mohan Kumar wrote:
> > > 
> > > This series add the support for TEGRA234 HDA driver support
> > > 
> > > Mohan Kumar (6):
> > >   ALSA: hda/tegra: Add Tegra234 hda driver support
> > >   ALSA: hda/tegra: Hardcode GCAP ISS value on T234
> > >   ALSA: hda/tegra: Update scratch reg. communication
> > >   dt-bindings: Add HDA support for Tegra234
> > >   dt-bindings: Document Tegra234 HDA support
> > >   arm64: tegra: Add hda dts node for Tegra234
> > 
> > Applied all six patches to for-next branch now.
> 
> ... and now I realized that it's conflicting with the latest Tegra234
> reset stuff on linux-next.
> 
> Maybe better to split the patches to be merged through several trees?

It's usually best for me to pick up at least the DT changes (patch 6)
into the Tegra tree, that way I can easily resolve conflicts there when
they arise.

The device tree bindings (patches 3 & 4) traditionally go along with
the driver changes, though.

If you prefer the patch series to be split, that's fine. For other
subsystems we usually deal with this by having one series and then the
subsystem maintainer picking up all the non-DT changes and I take the
rest.

Thierry
Takashi Iwai Feb. 16, 2022, 2:41 p.m. UTC | #5
On Wed, 16 Feb 2022 15:23:27 +0100,
Thierry Reding wrote:
> 
> On Tue, Feb 15, 2022 at 02:34:01PM +0100, Takashi Iwai wrote:
> > On Tue, 15 Feb 2022 14:29:54 +0100,
> > Takashi Iwai wrote:
> > > 
> > > On Thu, 10 Feb 2022 07:50:51 +0100,
> > > Mohan Kumar wrote:
> > > > 
> > > > This series add the support for TEGRA234 HDA driver support
> > > > 
> > > > Mohan Kumar (6):
> > > >   ALSA: hda/tegra: Add Tegra234 hda driver support
> > > >   ALSA: hda/tegra: Hardcode GCAP ISS value on T234
> > > >   ALSA: hda/tegra: Update scratch reg. communication
> > > >   dt-bindings: Add HDA support for Tegra234
> > > >   dt-bindings: Document Tegra234 HDA support
> > > >   arm64: tegra: Add hda dts node for Tegra234
> > > 
> > > Applied all six patches to for-next branch now.
> > 
> > ... and now I realized that it's conflicting with the latest Tegra234
> > reset stuff on linux-next.
> > 
> > Maybe better to split the patches to be merged through several trees?
> 
> It's usually best for me to pick up at least the DT changes (patch 6)
> into the Tegra tree, that way I can easily resolve conflicts there when
> they arise.
> 
> The device tree bindings (patches 3 & 4) traditionally go along with
> the driver changes, though.
> 
> If you prefer the patch series to be split, that's fine. For other
> subsystems we usually deal with this by having one series and then the
> subsystem maintainer picking up all the non-DT changes and I take the
> rest.

OK, that's fine for me.
Let's revisit the latest patchset.


thanks,

Takashi