mbox series

[RESEND,v2,0/6] ALSA: hda: Unify codec construction

Message ID 20220816111727.3218543-1-cezary.rojewski@intel.com (mailing list archive)
Headers show
Series ALSA: hda: Unify codec construction | expand

Message

Cezary Rojewski Aug. 16, 2022, 11:17 a.m. UTC 
A follow up to the recent HDAudio fixes series [1]. Given the recently
reported regression [2], before the page fault occurring on codec
shutdown can be fixed, codec construction procedure needs to be updated
for skylake and sof-intel drivers. Drivers: pci-hda and avs need no
changes - already making use of snd_hda_codec_device_init().

As subject touches code used by the sof-driver, additional review has
been conducted on thesofproject/linux [3].

Changes in v2:

- dropped snd_hda_ext_core <-> snd_hda_codec dependency by calling
  snd_hda_codec_device_init() directly in skylake and sof drivers probe
  enumeration routines, as suggested by Takashi
- skylake/sof portion of the change has been split into two separate
  patches

- new functions that aim to replace hdac_ext codec init & exit
  functionality are added first - for skylake and sof drivers both
- third patch in the series now combines the "field -> pointer" change
  for hdac_hda_priv->codec plus the codec-enumeration adjustments for
  skylake and sof drivers
  Both above are here to keep git bisect happy, as suggested by Pierre

[1]: https://lore.kernel.org/alsa-devel/20220706120230.427296-7-cezary.rojewski@intel.com/
[2]: https://lore.kernel.org/alsa-devel/3c40df55-3aee-1e08-493b-7b30cd84dc00@linux.intel.com/
[3]: https://github.com/thesofproject/linux/pull/3775

Cezary Rojewski (6):
  ASoC: Intel: Skylake: Introduce HDA codec init and exit routines
  ASoC: SOF: Intel: Introduce HDA codec init and exit routines
  ASoC: Intel: Drop hdac_ext usage for codec device creation
  ALSA: hda: Always free codec on the device release
  ALSA: hda: Remove codec init and exit routines
  ALSA: hda: Fix page fault in snd_hda_codec_shutdown()

 include/sound/hda_codec.h                    |  2 -
 include/sound/hdaudio_ext.h                  |  3 --
 sound/hda/ext/hdac_ext_bus.c                 | 53 -------------------
 sound/pci/hda/hda_codec.c                    | 49 ++++++++---------
 sound/soc/codecs/hdac_hda.c                  | 26 ++++-----
 sound/soc/codecs/hdac_hda.h                  |  2 +-
 sound/soc/intel/boards/hda_dsp_common.c      |  2 +-
 sound/soc/intel/boards/skl_hda_dsp_generic.c |  2 +-
 sound/soc/intel/skylake/skl.c                | 53 ++++++++++++++-----
 sound/soc/sof/intel/hda-codec.c              | 55 ++++++++++++++------
 10 files changed, 113 insertions(+), 134 deletions(-)

Comments

Cezary Rojewski Aug. 16, 2022, 11:30 a.m. UTC | #1 
On 2022-08-16 1:17 PM, Cezary Rojewski wrote:

...

> Cezary Rojewski (6):
>    ASoC: Intel: Skylake: Introduce HDA codec init and exit routines
>    ASoC: SOF: Intel: Introduce HDA codec init and exit routines
>    ASoC: Intel: Drop hdac_ext usage for codec device creation
>    ALSA: hda: Always free codec on the device release
>    ALSA: hda: Remove codec init and exit routines
>    ALSA: hda: Fix page fault in snd_hda_codec_shutdown()


All of these landed on lore.kernel.org without problems now.

The only thing I can think of that could offended the server is the 
incorrect email address that I had appended to hsw-bdw related series 
[1] which I'd sent before the unify-hda-ctor v2 one. Kai's email was 
provided twice there - by mistake - and the second copy is missing 'm' 
in '@linux.intel.com'. Perhaps these topics are not connected but it's 
the only offending action that I've managed to find.


Regards,
Czarek
Takashi Iwai Aug. 18, 2022, 7:52 a.m. UTC | #2 
On Tue, 16 Aug 2022 13:17:21 +0200,
Cezary Rojewski wrote:
> 
> A follow up to the recent HDAudio fixes series [1]. Given the recently
> reported regression [2], before the page fault occurring on codec
> shutdown can be fixed, codec construction procedure needs to be updated
> for skylake and sof-intel drivers. Drivers: pci-hda and avs need no
> changes - already making use of snd_hda_codec_device_init().
> 
> As subject touches code used by the sof-driver, additional review has
> been conducted on thesofproject/linux [3].
> 
> Changes in v2:
> 
> - dropped snd_hda_ext_core <-> snd_hda_codec dependency by calling
>   snd_hda_codec_device_init() directly in skylake and sof drivers probe
>   enumeration routines, as suggested by Takashi
> - skylake/sof portion of the change has been split into two separate
>   patches
> 
> - new functions that aim to replace hdac_ext codec init & exit
>   functionality are added first - for skylake and sof drivers both
> - third patch in the series now combines the "field -> pointer" change
>   for hdac_hda_priv->codec plus the codec-enumeration adjustments for
>   skylake and sof drivers
>   Both above are here to keep git bisect happy, as suggested by Pierre
> 
> [1]: https://lore.kernel.org/alsa-devel/20220706120230.427296-7-cezary.rojewski@intel.com/
> [2]: https://lore.kernel.org/alsa-devel/3c40df55-3aee-1e08-493b-7b30cd84dc00@linux.intel.com/
> [3]: https://github.com/thesofproject/linux/pull/3775
> 
> Cezary Rojewski (6):
>   ASoC: Intel: Skylake: Introduce HDA codec init and exit routines
>   ASoC: SOF: Intel: Introduce HDA codec init and exit routines
>   ASoC: Intel: Drop hdac_ext usage for codec device creation
>   ALSA: hda: Always free codec on the device release
>   ALSA: hda: Remove codec init and exit routines
>   ALSA: hda: Fix page fault in snd_hda_codec_shutdown()

Applied all patches now to for-next branch.  Thanks.


Takashi