mbox series

[v3,0/2] ASoC: Intel: avs: DSP recovery and resume fixes

Message ID 20221116115550.1100398-1-cezary.rojewski@intel.com (mailing list archive)
Headers show
Series ASoC: Intel: avs: DSP recovery and resume fixes | expand

Message

Cezary Rojewski Nov. 16, 2022, 11:55 a.m. UTC 
Two fixes that are result of the recent discussions [1][2].

First adds missing locking around snd_pcm_stop() while the second fix
sets substream state to DISCONNECTED if any suspend/resume related
operation fails so that userspace has means to be aware that something
went wrong during said operation.

Changes in v3:
- added a comment why non-_irq() locking is used around snd_pcm_stop()

Changes in v2:
- __snd_pcm_set_state() replaced direct assignments of PCM state


[1]: https://lore.kernel.org/alsa-devel/73e6425f-8e51-e26f-ad83-ccc5df517a43@intel.com/
[2]: https://lore.kernel.org/alsa-devel/20221104131244.3920179-1-cezary.rojewski@intel.com/

Cezary Rojewski (2):
  ASoC: Intel: avs: Lock substream before snd_pcm_stop()
  ASoC: Intel: avs: Disconnect substream if suspend or resume fails

 sound/soc/intel/avs/ipc.c |  3 +++
 sound/soc/intel/avs/pcm.c | 10 ++++++++--
 2 files changed, 11 insertions(+), 2 deletions(-)

Comments

Mark Brown Nov. 23, 2022, 1:11 p.m. UTC | #1 
On Wed, 16 Nov 2022 12:55:48 +0100, Cezary Rojewski wrote:
> Two fixes that are result of the recent discussions [1][2].
> 
> First adds missing locking around snd_pcm_stop() while the second fix
> sets substream state to DISCONNECTED if any suspend/resume related
> operation fails so that userspace has means to be aware that something
> went wrong during said operation.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: Intel: avs: Lock substream before snd_pcm_stop()
      commit: c30c8f9d51ec24b36e2c65a6307a5c8cbc5a0ebc
[2/2] ASoC: Intel: avs: Disconnect substream if suspend or resume fails
      commit: f3fbb553f98563f692e356aca87d656baba910a0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark