[v8,0/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

Message

Ricardo Ribalda Dec. 1, 2022, 11:08 a.m. UTC

Since: 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers in .shutdown")
we wait for all the workloads to be completed during shutdown. This was done to 
avoid a stall once the device is started again.

Unfortunately this has the side effect of stalling kexec(), if the userspace
is frozen. Let's handle that case.

To: Joel Fernandes <[e-mail]>
To: Pierre-Louis Bossart <[e-mail]>
To: Liam Girdwood <[e-mail]>
To: Peter Ujfalusi <[e-mail]>
To: Bard Liao <[e-mail]>
To: Ranjani Sridharan <[e-mail]>
To: Kai Vehmanen <[e-mail]>
To: Daniel Baluta <[e-mail]>
To: Mark Brown <[e-mail]>
To: Jaroslav Kysela <[e-mail]>
To: Takashi Iwai <[e-mail]>
To: Eric Biederman <[e-mail]>
To: Chromeos Kdump <[e-mail]>
To: Steven Rostedt <[e-mail]>
To: Michael Ellerman <[e-mail]>
To: Nicholas Piggin <[e-mail]>
To: Christophe Leroy <[e-mail]>
To: "K. Y. Srinivasan" <[e-mail]>
To: Haiyang Zhang <[e-mail]>
To: Wei Liu <[e-mail]>
To: Dexuan Cui <[e-mail]>
To: Thomas Gleixner <[e-mail]>
To: Ingo Molnar <[e-mail]>
To: Borislav Petkov <[e-mail]>
To: Dave Hansen <[e-mail]>
To: [e-mail]
To: "H. Peter Anvin" <[e-mail]>
To: Juergen Gross <[e-mail]>
To: Boris Ostrovsky <[e-mail]>
To: Ard Biesheuvel <[e-mail]>
To: Bjorn Helgaas <[e-mail]>
To: "Rafael J. Wysocki" <[e-mail]>
To: Pavel Machek <[e-mail]>
To: Len Brown <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Signed-off-by: Ricardo Ribalda <[e-mail]>
---
Changes in v8:
- Wrap pm_freezing and kexec_inprogress in functions.
- Do not run snd_sof_machine_unregister(sdev, pdata) during kexec (Thanks Kai).
- Link to v7: https://lore.kernel.org/r/[e-mail]

Changes in v7:
- Fix commit message (Thanks Pierre-Louis).
- Link to v6: https://lore.kernel.org/r/[e-mail]

Changes in v6:
- Check if we are in kexec with the userspace frozen.
- Link to v5: https://lore.kernel.org/r/[e-mail]

Changes in v5:
- Edit subject prefix.
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4:
- Do not call snd_sof_machine_unregister from shutdown.
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Wrap pm_freezing in a function.
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Only use pm_freezing if CONFIG_FREEZER .
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Ricardo Ribalda (3):
      kexec: Refactor kexec_in_progress into a function
      freezer: refactor pm_freezing into a function.
      ASoC: SOF: Fix deadlock when shutdown a frozen userspace

 arch/powerpc/platforms/pseries/vio.c |  2 +-
 arch/x86/kernel/cpu/mshyperv.c       |  6 +++---
 arch/x86/xen/enlighten_hvm.c         |  2 +-
 drivers/firmware/efi/efi.c           |  2 +-
 drivers/pci/pci-driver.c             |  2 +-
 include/linux/freezer.h              |  3 ++-
 include/linux/kexec.h                |  5 ++---
 kernel/freezer.c                     |  3 +--
 kernel/kexec_core.c                  | 12 ++++++++++--
 kernel/power/process.c               | 24 ++++++++++++++++++++----
 sound/soc/sof/core.c                 |  9 ++++++---
 11 files changed, 48 insertions(+), 22 deletions(-)
---
base-commit: 4312098baf37ee17a8350725e6e0d0e8590252d4
change-id: 20221127-snd-freeze-1ee143228326

Best regards,