[v2,00/11] Improve CS35l41-based audio codec drivers

Message

Cristian Ciocaltea Sept. 7, 2023, 5:09 p.m. UTC

This patch series contains several fixes and improvements to drivers
based on the CS35l41 audio codec.

It has been verified on Valve's Steam Deck, except the HDA related patches.

Changes in v2:
 - Added Acked-by tags from Charles
 - Reworked the shared boost handling per reviews from Charles and David
 - Dropped PATCH 5/9 and moved PATCH 6/9 a bit down the list, as it doesn't
   contain a Fixes tag
 - Reverted usage of devm_pm_runtime_enable() in PATCH 9/9 and replaced with
   a proper runtime PM changes undo in PATCH v2 06/11
 - Added 3 new patches providing some HDA related fixes
 - v1: https://lore.kernel.org/all/[e-mail]/

Cristian Ciocaltea (11):
  ASoC: cs35l41: Handle mdsync_down reg write errors
  ASoC: cs35l41: Handle mdsync_up reg write errors
  ASoC: cs35l41: Initialize completion object before requesting IRQ
  ASoC: cs35l41: Fix broken shared boost activation
  ASoC: cs35l41: Verify PM runtime resume errors in IRQ handler
  ASoC: cs35l41: Undo runtime PM changes at driver exit time
  ASoC: cs35l41: Make use of dev_err_probe()
  ASoC: cs35l41: Use modern pm_ops
  ALSA: hda: cs35l41: Fix unbalanced pm_runtime_get()
  ALSA: hda: cs35l41: Undo runtime PM changes at driver exit time
  ALSA: hda: cs35l41: Consistently use dev_err_probe()

 include/sound/cs35l41.h        |  4 +-
 sound/pci/hda/cs35l41_hda.c    | 23 +++++----
 sound/soc/codecs/cs35l41-i2c.c | 11 ++--
 sound/soc/codecs/cs35l41-lib.c | 60 +++++++++++++---------
 sound/soc/codecs/cs35l41-spi.c | 11 ++--
 sound/soc/codecs/cs35l41.c     | 93 +++++++++++++++++++---------------
 sound/soc/codecs/cs35l41.h     |  1 -
 7 files changed, 112 insertions(+), 91 deletions(-)

Comments

Mark Brown Sept. 7, 2023, 5:21 p.m. UTC | #1

On Thu, Sep 07, 2023 at 08:09:59PM +0300, Cristian Ciocaltea wrote:

>  - Added 3 new patches providing some HDA related fixes

Do these have any interaction with the rest of the series?

Cristian Ciocaltea Sept. 7, 2023, 5:27 p.m. UTC | #2

On 9/7/23 20:21, Mark Brown wrote:
> On Thu, Sep 07, 2023 at 08:09:59PM +0300, Cristian Ciocaltea wrote:
> 
>>  - Added 3 new patches providing some HDA related fixes
> 
> Do these have any interaction with the rest of the series?

Yes, PATCH v2 04/11 changed the signature of cs35l41_global_enable()
function which is also used by HDA - this is how I noticed the
additional issues.

Takashi Iwai Sept. 11, 2023, 6:25 a.m. UTC | #3

On Thu, 07 Sep 2023 19:27:42 +0200,
Cristian Ciocaltea wrote:
> 
> On 9/7/23 20:21, Mark Brown wrote:
> > On Thu, Sep 07, 2023 at 08:09:59PM +0300, Cristian Ciocaltea wrote:
> > 
> >>  - Added 3 new patches providing some HDA related fixes
> > 
> > Do these have any interaction with the rest of the series?
> 
> Yes, PATCH v2 04/11 changed the signature of cs35l41_global_enable()
> function which is also used by HDA - this is how I noticed the
> additional issues.

OK, then feel free to take my ack for HDA side:

Reviewed-by: Takashi Iwai <[e-mail]>


thanks,

Takashi

Mark Brown Sept. 11, 2023, 11:57 p.m. UTC | #4

On Thu, 07 Sep 2023 20:09:59 +0300, Cristian Ciocaltea wrote:
> This patch series contains several fixes and improvements to drivers
> based on the CS35l41 audio codec.
> 
> It has been verified on Valve's Steam Deck, except the HDA related patches.
> 
> Changes in v2:
>  - Added Acked-by tags from Charles
>  - Reworked the shared boost handling per reviews from Charles and David
>  - Dropped PATCH 5/9 and moved PATCH 6/9 a bit down the list, as it doesn't
>    contain a Fixes tag
>  - Reverted usage of devm_pm_runtime_enable() in PATCH 9/9 and replaced with
>    a proper runtime PM changes undo in PATCH v2 06/11
>  - Added 3 new patches providing some HDA related fixes
>  - v1: https://lore.kernel.org/all/[e-mail]/
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/11] ASoC: cs35l41: Handle mdsync_down reg write errors
        commit: a9a3f54a23d844971c274f352500dddeadb4412c
[02/11] ASoC: cs35l41: Handle mdsync_up reg write errors
        commit: 4bb5870ab60abca6ad18196090831b5e4cf82d93
[03/11] ASoC: cs35l41: Initialize completion object before requesting IRQ
        commit: 5ad668a9ce83d819701fb7abc1c2236049ec15c2
[04/11] ASoC: cs35l41: Fix broken shared boost activation
        commit: 77bf613f0bf08c021309cdb5f84b5f630b829261
[05/11] ASoC: cs35l41: Verify PM runtime resume errors in IRQ handler
        commit: 9f8948db9849d202dee3570507d3a0642f92d632
[06/11] ASoC: cs35l41: Undo runtime PM changes at driver exit time
        commit: 2d5661e6008ae1a1cd6df7cc844908fb8b982c58
[07/11] ASoC: cs35l41: Make use of dev_err_probe()
        commit: 3db52739aca981a436536423a36ab59b9f241096
[08/11] ASoC: cs35l41: Use modern pm_ops
        commit: 611b8813a28f49e206e05198dae77c544c72b050
[09/11] ALSA: hda: cs35l41: Fix unbalanced pm_runtime_get()
        commit: 486465508f8a5fe441939a7d97607f4460a60891
[10/11] ALSA: hda: cs35l41: Undo runtime PM changes at driver exit time
        commit: 85a1bf86fac0c195929768b4e92c78cad107523b
[11/11] ALSA: hda: cs35l41: Consistently use dev_err_probe()
        commit: 206b250c3e9be44c096bb9bb1f9d6b7f3440bfbb

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark