mbox series

[0/3] ALSA: hda: Stream setup fixes

Message ID 20231006102857.749143-1-cezary.rojewski@intel.com (mailing list archive)
Headers show
Series ALSA: hda: Stream setup fixes | expand

Message

Cezary Rojewski Oct. 6, 2023, 10:28 a.m. UTC 
Follow up to the recent hdac_stream-related series of mine [1].
Addresses three topics:

- false-positive timeout (-110) messages that appear during firmware
  loading procedure
- null-ptr-deref when assigning stub substream of COUPLED type. 'Stub'
  as precisely those kind of substreams are utilized for code-loading
  procedure
- hstream->fifo_size initialization, superfluous '+1'

The two fixes lead the way, there is no dependency of patch 3/3 on
either of them.


[1]: https://lore.kernel.org/alsa-devel/20230926080623.43927-1-cezary.rojewski@intel.com/

Cezary Rojewski (3):
  ALSA: hda: Fix possible null-ptr-deref when assigning a stream
  ALSA: hda: Fix stream fifo_size initialization
  ALSA: hda: Add code_loading parameter to stream setup

 include/sound/hdaudio.h           |  2 +-
 include/sound/hdaudio_ext.h       |  4 ++--
 sound/hda/ext/hdac_ext_stream.c   | 12 +++++++-----
 sound/hda/hdac_stream.c           | 27 ++++++++++++++++-----------
 sound/pci/hda/hda_controller.c    |  2 +-
 sound/pci/hda/hda_intel.c         |  2 +-
 sound/soc/intel/avs/pcm.c         |  2 +-
 sound/soc/intel/avs/probes.c      |  2 +-
 sound/soc/intel/skylake/skl-pcm.c |  2 +-
 9 files changed, 31 insertions(+), 24 deletions(-)

Comments

Takashi Iwai Oct. 6, 2023, 12:31 p.m. UTC | #1 
On Fri, 06 Oct 2023 12:28:54 +0200,
Cezary Rojewski wrote:
> 
> Follow up to the recent hdac_stream-related series of mine [1].
> Addresses three topics:
> 
> - false-positive timeout (-110) messages that appear during firmware
>   loading procedure
> - null-ptr-deref when assigning stub substream of COUPLED type. 'Stub'
>   as precisely those kind of substreams are utilized for code-loading
>   procedure
> - hstream->fifo_size initialization, superfluous '+1'
> 
> The two fixes lead the way, there is no dependency of patch 3/3 on
> either of them.
> 
> 
> [1]: https://lore.kernel.org/alsa-devel/20230926080623.43927-1-cezary.rojewski@intel.com/
> 
> Cezary Rojewski (3):
>   ALSA: hda: Fix possible null-ptr-deref when assigning a stream
>   ALSA: hda: Fix stream fifo_size initialization
>   ALSA: hda: Add code_loading parameter to stream setup

Applied all three patches now.  Thanks.


Takashi