From patchwork Sun Oct 29 16:57:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Otto_Pfl=C3=BCger?= X-Patchwork-Id: 13439836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 841D0C4332F for ; Sun, 29 Oct 2023 17:06:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbjJ2RGZ (ORCPT ); Sun, 29 Oct 2023 13:06:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230155AbjJ2RGX (ORCPT ); Sun, 29 Oct 2023 13:06:23 -0400 X-Greylist: delayed 506 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 29 Oct 2023 10:06:21 PDT Received: from srv01.abscue.de (abscue.de [89.58.28.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B98BFAF for ; Sun, 29 Oct 2023 10:06:21 -0700 (PDT) Received: from srv01.abscue.de (localhost [127.0.0.1]) by spamfilter.srv.local (Postfix) with ESMTP id B12CC1C258F; Sun, 29 Oct 2023 17:57:49 +0100 (CET) Received: from fluffy-mammal.fritz.box (dslb-088-078-198-137.088.078.pools.vodafone-ip.de [88.78.198.137]) by srv01.abscue.de (Postfix) with ESMTPSA id 3E4AD1C258E; Sun, 29 Oct 2023 17:57:49 +0100 (CET) From: =?utf-8?q?Otto_Pfl=C3=BCger?= To: linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Banajit Goswami , Liam Girdwood , Mark Brown , linux-sound@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?utf-8?q?Otto_Pfl=C3=BCger?= Subject: [PATCH v2 0/4] ASoC: qcom: check ADSP version when setting clocks Date: Sun, 29 Oct 2023 17:57:12 +0100 Message-Id: <20231029165716.69878-1-otto.pflueger@abscue.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-sound@vger.kernel.org The apq8016_sbc driver currently works on APQ8016 and MSM8916 devices. It should also work on MSM8909 (and newer SoCs like MSM8917 and MSM8953 if the quinary MI2S line is added); however, newer devices with these SoCs ship with newer firmware that uses a different interface for controlling the digital codec and bit clocks, which causes the driver to fail because it cannot set LPAIF_BIT_CLK. In order to fix this problem, modify the LPAIF_* clock implementation in the qdsp6 driver to use the newer clock API if a newer firmware version is detected. This seems to be a better solution than exposing the firmware version to other drivers like apq8016_sbc and forcing them to figure out which clock to use. On MSM8916, a hack is currently used to control the LPAIF_DIG_CLK directly through the GCC driver, but on devices with the newer firmware, the INTERNAL_DIGITAL_CODEC_CORE clock provided by q6afe-clocks in the qdsp6 driver can be used instead. Add a fallback to make this clock work with the older firmware too, allowing one to specify it as the codec's "mclk" in the device tree: compatible = "qcom,msm8916-wcd-digital-codec"; clocks = <&xo_board>, <&q6afecc LPASS_CLK_ID_INTERNAL_DIGITAL_CODEC_CORE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; clock-names = "ahbix", "mclk"; assigned-clocks = <&q6afecc LPASS_CLK_ID_INTERNAL_DIGITAL_CODEC_CORE LPASS_CLK_ATTRIBUTE_COUPLE_NO>; assigned-clock-rates = <9600000>; This works both on MSM8916 and on the newer SoCs mentioned above. --- Changes in v2: - Log unknown AVS versions - Move some checks to q6afe-dai as suggested by Srinivas - Also implement LPAIF_OSR_CLK for ports that have it Otto Pflüger (4): ASoC: qcom: q6core: expose ADSP core firmware version ASoC: qcom: q6afe: provide fallback for digital codec clock ASoC: qcom: q6afe-dai: check ADSP version when setting sysclk ASoC: qcom: q6afe: remove "port already open" error sound/soc/qcom/qdsp6/q6afe-dai.c | 98 +++++++++++++++++++++++++++----- sound/soc/qcom/qdsp6/q6afe.c | 30 +++++++++- sound/soc/qcom/qdsp6/q6core.c | 65 +++++++++++++++++++++ sound/soc/qcom/qdsp6/q6core.h | 9 +++ 4 files changed, 185 insertions(+), 17 deletions(-) base-commit: 66f1e1ea3548378ff6387b1ce0b40955d54e86aa