| Message ID | 20240313015853.3573242-1-me@jwang.link (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support" | expand |
On 13/03/24 07:28, Jiawei Wang wrote: > I would like to revert two of my previous commits after > realizing they incorrectly enabled the Yellow Carp > (YC) driver for Pink Sardine (PS) platforms. > > The first commit was reverted because it added a quirk entry > that incorrectly enabled the YC driver for the Lenovo 21J2 > laptop, which is a PS platform. > > The second commit was reverted because it incorrectly enabled > the YC driver for PS platforms. > > Thanks to Mukunda Vijendar [1] for pointing this out. > > Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1] > > v3 -> v2: > - No changes to content. > - Patches re-prepared using the broonie/sound.git tree's for-next branch. > v2 -> v1: > - No changes to content. Subject lines and commit messages were revised. > > On March 13, 2024 at 12:44 AM, Mark Brown wrote: >> This still doesn't apply against my for-6.9 branch. > I've updated the patch using your "for-next" tree. > > However, it can't be applied to the "for-6.9" branch, > because the commits to be reverted are not present in "for-6.9". > Below are their hashes: > ed00a69 ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2 > 316a784 ASoC: amd: yc: add new YC platform variant (0x63) support > > On March 13, 2024 at 12:50 AM, Mukunda,Vijendar wrote: >> You can prepare patch by cloning below git tree for-next branch. >> >> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git >> >> while sending patches, please use --cc-cmd=./scripts/get_maintainer.pl along >> with cc list. > Thank you for your guidance. I have updated the patch using > the "for-next" tree as suggested. Additionally, I've > incorporated the cc-cmd as per your instructions. Hi Mark, Could you please apply this patch series? Without these changes, functionality is broken for Pink Sardine (PS) platform. > > Jiawei Wang (2): > ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" > ASoC: amd: yc: Revert "add new YC platform variant (0x63) support" > > sound/soc/amd/yc/acp6x-mach.c | 7 ------- > sound/soc/amd/yc/pci-acp6x.c | 1 - > 2 files changed, 8 deletions(-) >
On Thu, Mar 14, 2024 at 10:44:27AM +0530, Mukunda,Vijendar wrote: > Could you please apply this patch series? Without these changes, functionality > is broken for Pink Sardine (PS) platform. Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed. Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.
On Wed, 13 Mar 2024 09:58:51 +0800, Jiawei Wang wrote: > I would like to revert two of my previous commits after > realizing they incorrectly enabled the Yellow Carp > (YC) driver for Pink Sardine (PS) platforms. > > The first commit was reverted because it added a quirk entry > that incorrectly enabled the YC driver for the Lenovo 21J2 > laptop, which is a PS platform. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" commit: 861b3415e4dee06cc00cd1754808a7827b9105bf [2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support" commit: 37bee1855d0e3b6dbeb8de71895f6f68cad137be All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark