From patchwork Mon Mar 25 11:31:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 13601962 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3517C54E58 for ; Mon, 25 Mar 2024 11:32:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 57E5B14EA; Mon, 25 Mar 2024 12:32:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 57E5B14EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1711366356; bh=MJQZPFsYuoWMOOKpqEWdDBSguutaxNezVILCQTDO434=; h=From:To:CC:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=VxgFYOo+5XkuNo4C18a7D1wqyM0RHYuSD/zWtZl+r2ET3J0FMEJpHK/2nnJEO2z+v CZGg7YtGtoMek6p7B5roKSORrZ+DzWCVmEtORis3dl2STCbPqh/klEQ1pAinkzfT6w eWGOauqSVAcqj/Z4DUZ+ALtDFhf38DqwSJljxbbo= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7027AF805AC; Mon, 25 Mar 2024 12:31:55 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3A42AF805AC; Mon, 25 Mar 2024 12:31:54 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 375A1F80564; Mon, 25 Mar 2024 12:31:38 +0100 (CET) Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7C710F80093 for ; Mon, 25 Mar 2024 12:31:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7C710F80093 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=BvWMcMW0 Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42P4qkf3007553; Mon, 25 Mar 2024 06:31:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=B GcWn7Vy3IP2SJ0lUTxgCUyOMlOORhPAToSh6yl/wik=; b=BvWMcMW0AFEJbcVpl N/H3iWdtmnkhlCD4K2IRAP4UwGO8uJQoagQlEmJIVyhs6yaIAeWRH4LtmhHSo/Sh x9HdataaQPk8HITz0EOvgZf9jwd/gluc+ewVc1kWkOAmf2u6HUoGDKC35l7EAlLe NPkRCV492Ylcl4BRzWRUgmxMRcIUTvHCaPcaNsjsPgIR44E/4BixNZLkKNF/XlL7 5lzpoFtjhtatZVDmFQf9SHCamPD/k4HMQ+xE3ncl6PnMVlDb7Uej6SlK4eyjxuS5 A78XYmMZFUnBimhddr1nseKug06ZneLBeZHTkoQB9HuCAkutqVs3CFHilqWyeZLL ptorA== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3x1vfyb6v0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Mar 2024 06:31:29 -0500 (CDT) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 25 Mar 2024 11:31:27 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 25 Mar 2024 11:31:27 +0000 Received: from ediswws06.ad.cirrus.com (ediswws06.ad.cirrus.com [198.90.208.18]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id 2DEC7820241; Mon, 25 Mar 2024 11:31:27 +0000 (UTC) From: Richard Fitzgerald To: , CC: , , , , "Richard Fitzgerald" Subject: [PATCH 0/5] ALSA: cirrus: Tidy up of firmware control read/write Date: Mon, 25 Mar 2024 11:31:22 +0000 Message-ID: <20240325113127.112783-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: eEuzHHeve88IErOHMGl7VLKzH3MtdUFP X-Proofpoint-GUID: eEuzHHeve88IErOHMGl7VLKzH3MtdUFP X-Proofpoint-Spam-Reason: safe Message-ID-Hash: LSUSDGKYXQZXCUQIDUKHEFLKHUYUCQI2 X-Message-ID-Hash: LSUSDGKYXQZXCUQIDUKHEFLKHUYUCQI2 X-MailFrom: prvs=081491209a=rf@opensource.cirrus.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This set of patches factors out some repeated code to clean up firmware control read/write functions, and removes some redundant control notification code. Simon Trimmer (5): firmware: cs_dsp: Add locked wrappers for coeff read and write ASoC: wm_adsp: Use cs_dsp_coeff_lock_and_[read|write]_ctrl() ALSA: hda: hda_cs_dsp_ctl: Use cs_dsp_coeff_lock_and_[read|write]_ctrl() ASoC: wm_adsp: Remove notification of driver write ALSA: hda: hda_cs_dsp_ctl: Remove notification of driver write drivers/firmware/cirrus/cs_dsp.c | 54 ++++++++++++++++++++++++++ include/linux/firmware/cirrus/cs_dsp.h | 4 ++ sound/pci/hda/hda_cs_dsp_ctl.c | 22 +---------- sound/soc/codecs/wm_adsp.c | 32 ++++----------- 4 files changed, 67 insertions(+), 45 deletions(-) Reviewed-by: Takashi Iwai