[0/6] ASoC: rt-sdw: fix locking and improve error logs

Message

Pierre-Louis Bossart March 25, 2024, 10:18 p.m. UTC

Fix a set of problematic locking sequences and update error messages,
tested on SOF/SoundWire platforms.

Pierre-Louis Bossart (6):
  ASoC: rt5682-sdw: fix locking sequence
  ASoC: rt711-sdca: fix locking sequence
  ASoC: rt711-sdw: fix locking sequence
  ASoC: rt712-sdca-sdw: fix locking sequence
  ASoC: rt722-sdca-sdw: fix locking sequence
  ASoC: rt-sdw*: add __func__ to all error logs

 sound/soc/codecs/rt1316-sdw.c      |  8 +++---
 sound/soc/codecs/rt1318-sdw.c      |  8 +++---
 sound/soc/codecs/rt5682-sdw.c      | 16 +++++------
 sound/soc/codecs/rt700.c           | 16 +++++------
 sound/soc/codecs/rt711-sdca-sdw.c  |  6 ++--
 sound/soc/codecs/rt711-sdca.c      | 18 ++++++------
 sound/soc/codecs/rt711-sdw.c       |  8 +++---
 sound/soc/codecs/rt711.c           | 16 +++++------
 sound/soc/codecs/rt712-sdca-dmic.c | 24 +++++++++-------
 sound/soc/codecs/rt712-sdca-sdw.c  |  7 +++--
 sound/soc/codecs/rt712-sdca.c      | 20 ++++++-------
 sound/soc/codecs/rt715-sdca-sdw.c  |  2 +-
 sound/soc/codecs/rt715-sdca.c      | 46 +++++++++++++++---------------
 sound/soc/codecs/rt715-sdw.c       |  4 +--
 sound/soc/codecs/rt715.c           | 24 ++++++++--------
 sound/soc/codecs/rt722-sdca-sdw.c  |  4 +--
 sound/soc/codecs/rt722-sdca.c      | 21 +++++++-------
 17 files changed, 126 insertions(+), 122 deletions(-)

Comments

Mark Brown March 25, 2024, 10:49 p.m. UTC | #1

On Mon, Mar 25, 2024 at 05:18:11PM -0500, Pierre-Louis Bossart wrote:
> Fix a set of problematic locking sequences and update error messages,
> tested on SOF/SoundWire platforms.
> 
> Pierre-Louis Bossart (6):
>   ASoC: rt5682-sdw: fix locking sequence
>   ASoC: rt711-sdca: fix locking sequence
>   ASoC: rt711-sdw: fix locking sequence
>   ASoC: rt712-sdca-sdw: fix locking sequence
>   ASoC: rt722-sdca-sdw: fix locking sequence
>   ASoC: rt-sdw*: add __func__ to all error logs

Copying some of the Realtek people for review.

Mark Brown March 29, 2024, 12:34 p.m. UTC | #2

On Mon, 25 Mar 2024 17:18:11 -0500, Pierre-Louis Bossart wrote:
> Fix a set of problematic locking sequences and update error messages,
> tested on SOF/SoundWire platforms.
> 
> Pierre-Louis Bossart (6):
>   ASoC: rt5682-sdw: fix locking sequence
>   ASoC: rt711-sdca: fix locking sequence
>   ASoC: rt711-sdw: fix locking sequence
>   ASoC: rt712-sdca-sdw: fix locking sequence
>   ASoC: rt722-sdca-sdw: fix locking sequence
>   ASoC: rt-sdw*: add __func__ to all error logs
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/6] ASoC: rt5682-sdw: fix locking sequence
      commit: 310a5caa4e861616a27a83c3e8bda17d65026fa8
[2/6] ASoC: rt711-sdca: fix locking sequence
      commit: ee287771644394d071e6a331951ee8079b64f9a7
[3/6] ASoC: rt711-sdw: fix locking sequence
      commit: aae86cfd8790bcc7693a5a0894df58de5cb5128c
[4/6] ASoC: rt712-sdca-sdw: fix locking sequence
      commit: c8b2e5c1b959d100990e4f0cbad38e7d047bb97c
[5/6] ASoC: rt722-sdca-sdw: fix locking sequence
      commit: adb354bbc231b23d3a05163ce35c1d598512ff64
[6/6] ASoC: rt-sdw*: add __func__ to all error logs
      commit: f892e66fcabc6161cd38c0fc86e769208174b840

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark