[0/2] ASoC: Intel: avs: Refactor IRQ handling

Message

Cezary Rojewski April 19, 2024, 8:48 a.m. UTC

The existing code can be both improved and simplified. To make this
change easier to manage, first add new implementation and then remove
deadcode in a separate patch.

Simplification achieved with:

- reduce the amount of resources requested by the driver i.e.: IPC and
  CLDMA request_irq() merged into one
- reduce the number of DSP ops from 2 to 1:
  irq_handler/thread() vs dsp_interrupt()
- drop ambiguity around CLDMA interrupt, let skl.c handle that
  explicitly as it is the only user

With that done, switch to the new implementation and remove unused
members. While the change is non-trivial, from functional perspective
status quo is achieved.

Cezary Rojewski (2):
  ASoC: Intel: avs: New IRQ handling implementation
  ASoC: Intel: avs: Remove unused IRQ-related code

 sound/soc/intel/avs/apl.c   | 20 +++++++-
 sound/soc/intel/avs/avs.h   |  8 ++--
 sound/soc/intel/avs/cldma.c | 42 ++++-------------
 sound/soc/intel/avs/cldma.h |  1 +
 sound/soc/intel/avs/cnl.c   | 91 ++++++++++++++++++++++++-------------
 sound/soc/intel/avs/core.c  | 85 ++++++++++++++++------------------
 sound/soc/intel/avs/icl.c   |  3 +-
 sound/soc/intel/avs/ipc.c   | 48 -------------------
 sound/soc/intel/avs/skl.c   | 73 +++++++++++++++++++++--------
 sound/soc/intel/avs/tgl.c   |  3 +-
 10 files changed, 186 insertions(+), 188 deletions(-)

Comments

Mark Brown April 21, 2024, 1:03 a.m. UTC | #1

On Fri, 19 Apr 2024 10:48:55 +0200, Cezary Rojewski wrote:
> The existing code can be both improved and simplified. To make this
> change easier to manage, first add new implementation and then remove
> deadcode in a separate patch.
> 
> Simplification achieved with:
> 
> - reduce the amount of resources requested by the driver i.e.: IPC and
>   CLDMA request_irq() merged into one
> - reduce the number of DSP ops from 2 to 1:
>   irq_handler/thread() vs dsp_interrupt()
> - drop ambiguity around CLDMA interrupt, let skl.c handle that
>   explicitly as it is the only user
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: Intel: avs: New IRQ handling implementation
      commit: 7ce6ceeb77bfd9fb0b22203190bd6f57fe917b51
[2/2] ASoC: Intel: avs: Remove unused IRQ-related code
      commit: 84049e2db59ad9b09461b6d7ec56bd3e8fe75eca

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark