[0/8] ASoC: Intel: avs: PCM code cleanup

Message

Cezary Rojewski April 26, 2024, 9:57 a.m. UTC

A set of changes that aims to improve readability of cohesiveness of the
pcm code for the avs-driver.

Start off with a change that synchronizes DAI open/close - DAIs are
started up in ascending order yet their shutdown does not follow the
scheme - it is done in the ascending order too, rather than desceding
one. This patch is a dependency for the next one in line.

To align the HDAudio DAI startup/shutdown with the non-HDAudio
equivalents, relocate the code from component to DAI. The reason above
is a dependency stems from codec driver requirements - HDAudio code
found in sound/pci/hda/ expects substream->runtime->private_data to
point to a valid stream (HOST) pointer.

With the hard part done, the follow up changes update the existing code
to reduce it is complexity - removal of duplicates, renaming of
ambiguous functions and adding new fields to DAI-data object so that the
number of local variables and casts is reduced.

Cezary Rojewski (8):
  ASoC: pcm: Reverse iterate DAIs when shutting them down
  ASoC: Intel: avs: Relocate HDA BE DAI specific operations
  ASoC: Intel: avs: Remove redundancy around DAI shutdown
  ASoC: Intel: avs: Store pointer to adev in DAI dma_data
  ASoC: Intel: avs: Remove redundancy around DAI startup
  ASoC: Intel: avs: Remove redundancy around DAI prepare
  ASoC: Intel: avs: Store pointer to link_stream in dma_data
  ASoC: Intel: avs: Clean up hw constraints initialization

 include/sound/soc.h       |   4 +
 sound/soc/intel/avs/pcm.c | 250 +++++++++++++++++---------------------
 sound/soc/soc-pcm.c       |   2 +-
 3 files changed, 117 insertions(+), 139 deletions(-)

Comments

Mark Brown May 1, 2024, 1:43 p.m. UTC | #1

On Fri, 26 Apr 2024 11:57:25 +0200, Cezary Rojewski wrote:
> A set of changes that aims to improve readability of cohesiveness of the
> pcm code for the avs-driver.
> 
> Start off with a change that synchronizes DAI open/close - DAIs are
> started up in ascending order yet their shutdown does not follow the
> scheme - it is done in the ascending order too, rather than desceding
> one. This patch is a dependency for the next one in line.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/8] ASoC: pcm: Reverse iterate DAIs when shutting them down
      commit: 31a70a71b3a730aa703bbd05713d21115dd6d33a
[2/8] ASoC: Intel: avs: Relocate HDA BE DAI specific operations
      commit: 140df6d4d5f541e950a35cad2e3dffb49186ed74
[3/8] ASoC: Intel: avs: Remove redundancy around DAI shutdown
      commit: b9d59f970ea7772957f6da02ca1ba272ef4495b8
[4/8] ASoC: Intel: avs: Store pointer to adev in DAI dma_data
      commit: c303a994e5d0f7d297cb6ac56052dce8f412ee67
[5/8] ASoC: Intel: avs: Remove redundancy around DAI startup
      commit: 3a48d146aa761bc591272bc453eda64743128a31
[6/8] ASoC: Intel: avs: Remove redundancy around DAI prepare
      commit: 0f8843ca4f6cbf0efb8c2d5516a3b92fb2771a04
[7/8] ASoC: Intel: avs: Store pointer to link_stream in dma_data
      commit: cdcb770a60e8e6b9fbb737ebe21b2daadaba1744
[8/8] ASoC: Intel: avs: Clean up hw constraints initialization
      commit: e85e75b67993c1fb0c80306783c31266261170d4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark