mbox series

[v2,0/6] ASoC: Add NTP8918 and NTP8835 codecs support

Message ID 20240709221203.92167-1-ivprusov@salutedevices.com (mailing list archive)
Headers show
Series ASoC: Add NTP8918 and NTP8835 codecs support | expand

Message

Igor Prusov July 9, 2024, 10:11 p.m. UTC 
This series adds support for two NeoFidelity amplifiers. For both
amplifiers vendor provides software for equalizer and filters
configuration, which generates firmware files with registers values.
Since in both cases those files have same encoding, a common helper
module is added to get firmware via request_firmware() API and set
registers values.

V1: https://lore.kernel.org/all/20240709172834.9785-1-ivprusov@salutedevices.com/

V1 -> V2:
 - Fix dt_binding_check errors

Igor Prusov (6):
  dt-bindings: vendor-prefixes: Add NeoFidelity, Inc
  ASoC: codecs: Add NeoFidelity Firmware helpers
  ASoC: dt-bindings: Add bindings for NeoFidelity NTP8918
  ASoC: codecs: Add NeoFidelity NTP8918 codec
  ASoC: dt-bindings: Add bindings for NeoFidelity NTP8835
  ASoC: codecs: Add NeoFidelity NTP8835 codec

 .../bindings/sound/neofidelity,ntp8835.yaml   |  64 +++
 .../bindings/sound/neofidelity,ntp8918.yaml   |  62 +++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 sound/soc/codecs/Kconfig                      |  13 +
 sound/soc/codecs/Makefile                     |   6 +
 sound/soc/codecs/ntp8835.c                    | 432 ++++++++++++++++++
 sound/soc/codecs/ntp8918.c                    | 356 +++++++++++++++
 sound/soc/codecs/ntpfw.c                      | 137 ++++++
 sound/soc/codecs/ntpfw.h                      |  23 +
 9 files changed, 1095 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/neofidelity,ntp8835.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/neofidelity,ntp8918.yaml
 create mode 100644 sound/soc/codecs/ntp8835.c
 create mode 100644 sound/soc/codecs/ntp8918.c
 create mode 100644 sound/soc/codecs/ntpfw.c
 create mode 100644 sound/soc/codecs/ntpfw.h

Comments

Rob Herring July 11, 2024, 9:10 p.m. UTC | #1 
On Wed, Jul 10, 2024 at 01:11:57AM +0300, Igor Prusov wrote:
> This series adds support for two NeoFidelity amplifiers. For both
> amplifiers vendor provides software for equalizer and filters
> configuration, which generates firmware files with registers values.
> Since in both cases those files have same encoding, a common helper
> module is added to get firmware via request_firmware() API and set
> registers values.
> 
> V1: https://lore.kernel.org/all/20240709172834.9785-1-ivprusov@salutedevices.com/
> 
> V1 -> V2:
>  - Fix dt_binding_check errors

Please implement the comments on v1. Please don't send new versions 
right away and give people time to review. We're not all on the same 
timezone, get busy on other tasks, take vacation, etc.

Rob
Igor Prusov July 12, 2024, 9:43 p.m. UTC | #2 
On Thu, Jul 11, 2024 at 03:10:14PM -0600, Rob Herring wrote:
> On Wed, Jul 10, 2024 at 01:11:57AM +0300, Igor Prusov wrote:
> > This series adds support for two NeoFidelity amplifiers. For both
> > amplifiers vendor provides software for equalizer and filters
> > configuration, which generates firmware files with registers values.
> > Since in both cases those files have same encoding, a common helper
> > module is added to get firmware via request_firmware() API and set
> > registers values.
> > 
> > V1: https://lore.kernel.org/all/20240709172834.9785-1-ivprusov@salutedevices.com/
> > 
> > V1 -> V2:
> >  - Fix dt_binding_check errors
> 
> Please implement the comments on v1. Please don't send new versions 
> right away and give people time to review. We're not all on the same 
> timezone, get busy on other tasks, take vacation, etc.
Hello, Rob,

Sorry, I' ve sent v2 before getting all comments on v1, I'll make sure
not to rush with new versions in the future.

> 
> Rob