mbox series

[0/2] Add a driver for the Iron Device SMA1307 Amp

Message ID 20240813052609.56527-1-kiseok.jo@irondevice.com (mailing list archive)
Headers show
Series Add a driver for the Iron Device SMA1307 Amp | expand

Message

Ki-Seok Jo Aug. 13, 2024, 5:26 a.m. UTC 
This adds basic audio support for the Iron Device SMA1307 amplifier

Kiseok Jo (2):
  ASoC: sma1307: Add driver for Iron Device SMA1307
  ASoC: sma1307: Add bindings for Iron Device SMA1307 amplifier

 .../bindings/sound/irondevice,sma1307.yaml    |   67 +
 sound/soc/codecs/Kconfig                      |    8 +
 sound/soc/codecs/Makefile                     |    2 +
 sound/soc/codecs/sma1307.c                    | 2630 +++++++++++++++++
 sound/soc/codecs/sma1307.h                    |  456 +++
 5 files changed, 3163 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml
 create mode 100644 sound/soc/codecs/sma1307.c
 create mode 100644 sound/soc/codecs/sma1307.h

Comments

Krzysztof Kozlowski Aug. 13, 2024, 6:48 a.m. UTC | #1 
On 13/08/2024 07:26, Kiseok Jo wrote:
> This adds basic audio support for the Iron Device SMA1307 amplifier
> 
> Kiseok Jo (2):
>   ASoC: sma1307: Add driver for Iron Device SMA1307
>   ASoC: sma1307: Add bindings for Iron Device SMA1307 amplifier

Why do you send the same stuff second time, without addressing feedback?

No, please version your patches, provide changelog, respond to comments
and then send a v3 with all above.

Best regards,
Krzysztof
Ki-Seok Jo Aug. 13, 2024, 6:52 a.m. UTC | #2 
I thought I should send it the same way because it is still an unregistered file. I believed I should post the patch after making modifications following registration. I will increase the patch version number in future submissions.


> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Tuesday, August 13, 2024 3:48 PM
> To: Ki-Seok Jo <kiseok.jo@irondevice.com>; Liam Girdwood
> <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; Jaroslav Kysela
> <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org; linux-sound@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 0/2] Add a driver for the Iron Device SMA1307 Amp
> 
> On 13/08/2024 07:26, Kiseok Jo wrote:
> > This adds basic audio support for the Iron Device SMA1307 amplifier
> >
> > Kiseok Jo (2):
> >   ASoC: sma1307: Add driver for Iron Device SMA1307
> >   ASoC: sma1307: Add bindings for Iron Device SMA1307 amplifier
> 
> Why do you send the same stuff second time, without addressing feedback?
> 
> No, please version your patches, provide changelog, respond to comments
> and then send a v3 with all above.
> 
> Best regards,
> Krzysztof