[0/4] ASoC/SoundWire: clean up link DMA during stop for IPC4

Message

Bard Liao Oct. 16, 2024, 3:29 a.m. UTC

Clean up the link DMA for playback during stop for IPC4 is required to
reset the DMA read/write pointers when the stream is prepared and
restarted after a call to snd_pcm_drain()/snd_pcm_drop(). 

The change is mainly on ASoC. We may go via ASoC tree with Vinod's
Acked-by tag

Ranjani Sridharan (4):
  ASoC: SOF: ipc4-topology: Do not set ALH node_id for aggregated DAIs
  ASoC: SOF: Intel: hda: Handle prepare without close for non-HDA DAI's
  soundwire: intel_ace2x: Send PDI stream number during prepare
  ASoC: SOF: Intel: hda: Always clean up link DMA during stop

 drivers/soundwire/intel_ace2x.c   | 19 +++++-----------
 sound/soc/sof/intel/hda-dai-ops.c | 23 +++++++++----------
 sound/soc/sof/intel/hda-dai.c     | 37 +++++++++++++++++++++++++++----
 sound/soc/sof/ipc4-topology.c     | 15 +++++++++++--
 4 files changed, 62 insertions(+), 32 deletions(-)

Comments

Bard Liao Oct. 16, 2024, 1:58 p.m. UTC | #1

On 10/16/2024 11:29 AM, Bard Liao wrote:
> Clean up the link DMA for playback during stop for IPC4 is required to
> reset the DMA read/write pointers when the stream is prepared and
> restarted after a call to snd_pcm_drain()/snd_pcm_drop(). 
> 
> The change is mainly on ASoC. We may go via ASoC tree with Vinod's
> Acked-by tag
> 

Mark,

This is a bug fix. Link: https://github.com/thesofproject/sof/issues/9502

Can you pick it for kernel 6.12? Also

All: Cc: [e-mail] # 6.10.x 6.11.x

Thanks,
Bard

> Ranjani Sridharan (4):
>   ASoC: SOF: ipc4-topology: Do not set ALH node_id for aggregated DAIs
>   ASoC: SOF: Intel: hda: Handle prepare without close for non-HDA DAI's
>   soundwire: intel_ace2x: Send PDI stream number during prepare
>   ASoC: SOF: Intel: hda: Always clean up link DMA during stop
> 
>  drivers/soundwire/intel_ace2x.c   | 19 +++++-----------
>  sound/soc/sof/intel/hda-dai-ops.c | 23 +++++++++----------
>  sound/soc/sof/intel/hda-dai.c     | 37 +++++++++++++++++++++++++++----
>  sound/soc/sof/ipc4-topology.c     | 15 +++++++++++--
>  4 files changed, 62 insertions(+), 32 deletions(-)
>

Mark Brown Oct. 18, 2024, 9:30 p.m. UTC | #2

On Wed, 16 Oct 2024 11:29:06 +0800, Bard Liao wrote:
> Clean up the link DMA for playback during stop for IPC4 is required to
> reset the DMA read/write pointers when the stream is prepared and
> restarted after a call to snd_pcm_drain()/snd_pcm_drop().
> 
> The change is mainly on ASoC. We may go via ASoC tree with Vinod's
> Acked-by tag
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/4] ASoC: SOF: ipc4-topology: Do not set ALH node_id for aggregated DAIs
      commit: 9822b4c90d77e3c6555fb21c459c4a61c6a8619f
[2/4] ASoC: SOF: Intel: hda: Handle prepare without close for non-HDA DAI's
      commit: 6e38a7e098d32d128b00b42a536151de9ea1340b
[3/4] soundwire: intel_ace2x: Send PDI stream number during prepare
      commit: c78f1e15e46ac82607eed593b22992fd08644d96
[4/4] ASoC: SOF: Intel: hda: Always clean up link DMA during stop
      commit: ab5593793e9088abcddce30ba8e376e31b7285fd

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark