mbox series

[v2,0/3] ASoC: add CS42L84 codec driver

Message ID 20241020-cs42l84-v2-0-37ba2b6721d9@gmail.com (mailing list archive)
Headers show
Series ASoC: add CS42L84 codec driver | expand

Message

James Calligeros Oct. 19, 2024, 2:47 p.m. UTC
Hi all,

This is version 2 of the Cirrus Logic CS42L84 ASoC codec driver.

This patch set adds a driver for the Cirrus Logic CS42L84 codec. This chip
is (so far) found only on Apple Silicon Macs. In keeping with proud Apple
tradition, the CS42L84 is essentially just a CS42L42 with a different
regmap and no publicly available datasheet. It may also be missing its
parent's S/PDIF capabilities as none of Apple's devices support S/PDIF out,
however this cannot be positively confirmed.

This driver has lived in the downstream Asahi tree for quite a while now,
and gained some refinements along the way. I have squashed most of these
into the initial driver commit as they were small changes like tweaking
msleep()s or filling out TLVs, but left seperate a larger change to
tip/ring sense IRQ handling as it differs significantly from what is found
in the CS42L42 driver.

---
Changes in v2:
- Fixed failing DT binding checks. Sorry! (Patch 1)

- Added Martin's name to the DT binding maintainer list (Patch 1)

- Documented #sound-dai-cells property in DT binding (Patch 1)

- Dropped superfluous DT binding descriptions (Patch 1)

- Fixed DT binding description whitespace  (Patch 1)

- Fixed licence comment format in cs42l42.h (Patch 2)

- Fixed erroneous whitespace in cs42l84.h (Patch 2)

- Switched driver to use maple tree for regcache (Patch 2)

- Lowered max_register property to address of highest observed register (Patch 2)

- Fixed switch/case statement style (Patches 2, 3)

- Picked up Neal's Reviewed-by

- Link to v1: https://lore.kernel.org/r/20241016-cs42l84-v1-0-8d7e9d437d2d@gmail.com

---
James Calligeros (1):
      ASoC: cs42l84: leverage ring sense IRQs to correctly detect headsets

Martin PoviĊĦer (2):
      dt-bindings: sound: Add CS42L84 codec
      ASoC: cs42l84: Add new codec driver

 .../bindings/sound/cirrus,cs42l84.yaml   |   56 ++
 MAINTAINERS                              |    2 +
 sound/soc/codecs/Kconfig                 |    7 +
 sound/soc/codecs/Makefile                |    2 +
 sound/soc/codecs/cs42l84.c               | 1112 +++++++++++++++++++++++++
 sound/soc/codecs/cs42l84.h               |  210 +++++
 6 files changed, 1389 insertions(+)
---
base-commit: 469819cc17368702a6f68cec2148f518d3f3679b
change-id: 20241016-cs42l84-f38348d21c88

Best regards,

Comments

Mark Brown Oct. 24, 2024, 8:16 p.m. UTC | #1
On Sun, 20 Oct 2024 00:47:30 +1000, James Calligeros wrote:
> This is version 2 of the Cirrus Logic CS42L84 ASoC codec driver.
> 
> This patch set adds a driver for the Cirrus Logic CS42L84 codec. This chip
> is (so far) found only on Apple Silicon Macs. In keeping with proud Apple
> tradition, the CS42L84 is essentially just a CS42L42 with a different
> regmap and no publicly available datasheet. It may also be missing its
> parent's S/PDIF capabilities as none of Apple's devices support S/PDIF out,
> however this cannot be positively confirmed.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] dt-bindings: sound: Add CS42L84 codec
      commit: f2a67da9f4eb03f5402acb9aeb65b23cac990827
[2/3] ASoC: cs42l84: Add new codec driver
      commit: 250304a0fb34bb74f4726645ae24dc31d7582a22
[3/3] ASoC: cs42l84: leverage ring sense IRQs to correctly detect headsets
      commit: 2391b8719d686b1947b5f81250281fa112da91dc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark