mbox series

[v5,0/3] Add support for codec of F1C100s

Message ID 20241102125712.2647325-1-csokas.bence@prolan.hu (mailing list archive)
Headers show
Series Add support for codec of F1C100s | expand

Message

Csókás Bence Nov. 2, 2024, 12:57 p.m. UTC
Support for Allwinner F1C100s/200s series audio was
submitted in 2018 as an RFC series, but was not merged,
despite having only minor errors. However, this is
essential for having audio on these SoCs.
This series was forward-ported/rebased to the best of
my abilities, on top of Linus' tree as of now:
commit c2ee9f594da8 ("KVM: selftests: Fix build on on non-x86 architectures")

Link: https://lore.kernel.org/all/cover.1543782328.git.mesihkilinc@gmail.com/

As requested by many, this series will now be split in 2, the DMA and the
ALSA/ASoC codec driver. This is the codec part of the series.
The first part (DMA) can be seen here. This series can be applied and
built without the former, but for working audio you need them both,
plus add it to Device Tree.
Link: https://lore.kernel.org/linux-kernel/20241102093140.2625230-2-csokas.bence@prolan.hu/

Csókás, Bence (1):
  dt-bindings: sound: Add Allwinner suniv F1C100s Audio Codec

Mesih Kilinc (2):
  ASoC: sun4i-codec: Add DMA Max Burst field
  ASoC: sun4i-codec: Add support for Allwinner suniv F1C100s

 .../sound/allwinner,sun4i-a10-codec.yaml      |  31 ++
 sound/soc/sunxi/sun4i-codec.c                 | 365 +++++++++++++++++-
 2 files changed, 394 insertions(+), 2 deletions(-)

Comments

Csókás Bence Nov. 15, 2024, 1:10 p.m. UTC | #1
So, if there's no further remarks, can this be merged? The next window 
is coming up, and there's the DT addition still waiting in the pipe.
Bence

On 2024. 11. 02. 13:57, Csókás, Bence wrote:
> Support for Allwinner F1C100s/200s series audio was
> submitted in 2018 as an RFC series, but was not merged,
> despite having only minor errors. However, this is
> essential for having audio on these SoCs.
> This series was forward-ported/rebased to the best of
> my abilities, on top of Linus' tree as of now:
> commit c2ee9f594da8 ("KVM: selftests: Fix build on on non-x86 architectures")
> 
> Link: https://lore.kernel.org/all/cover.1543782328.git.mesihkilinc@gmail.com/
> 
> As requested by many, this series will now be split in 2, the DMA and the
> ALSA/ASoC codec driver. This is the codec part of the series.
> The first part (DMA) can be seen here. This series can be applied and
> built without the former, but for working audio you need them both,
> plus add it to Device Tree.
> Link: https://lore.kernel.org/linux-kernel/20241102093140.2625230-2-csokas.bence@prolan.hu/
> 
> Csókás, Bence (1):
>    dt-bindings: sound: Add Allwinner suniv F1C100s Audio Codec
> 
> Mesih Kilinc (2):
>    ASoC: sun4i-codec: Add DMA Max Burst field
>    ASoC: sun4i-codec: Add support for Allwinner suniv F1C100s
> 
>   .../sound/allwinner,sun4i-a10-codec.yaml      |  31 ++
>   sound/soc/sunxi/sun4i-codec.c                 | 365 +++++++++++++++++-
>   2 files changed, 394 insertions(+), 2 deletions(-)
>
Mark Brown Nov. 15, 2024, 3:07 p.m. UTC | #2
On Fri, Nov 15, 2024 at 02:10:18PM +0100, Csókás Bence wrote:
> So, if there's no further remarks, can this be merged? The next window is
> coming up, and there's the DT addition still waiting in the pipe.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
Mark Brown Dec. 3, 2024, 5:50 p.m. UTC | #3
On Sat, 02 Nov 2024 13:57:09 +0100, Csókás, Bence wrote:
> Support for Allwinner F1C100s/200s series audio was
> submitted in 2018 as an RFC series, but was not merged,
> despite having only minor errors. However, this is
> essential for having audio on these SoCs.
> This series was forward-ported/rebased to the best of
> my abilities, on top of Linus' tree as of now:
> commit c2ee9f594da8 ("KVM: selftests: Fix build on on non-x86 architectures")
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: sun4i-codec: Add DMA Max Burst field
      commit: cabd4ac290a6ceb87c8dbfb5a3251750e24529e7
[2/3] dt-bindings: sound: Add Allwinner suniv F1C100s Audio Codec
      (no commit info)
[3/3] ASoC: sun4i-codec: Add support for Allwinner suniv F1C100s
      commit: 2198deb823a6ebe110b737614421a4687d3327f4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark