mbox series

[v2,0/2] ALSA: hda/realtek: Sort Ally X properly, fix Asus Z13 2025 audio

Message ID 20250227175107.33432-1-lkml@antheas.dev (mailing list archive)
Headers show
Series ALSA: hda/realtek: Sort Ally X properly, fix Asus Z13 2025 audio | expand

Message

Antheas Kapenekakis Feb. 27, 2025, 5:51 p.m. UTC
The Ally X has two quirks in the kernel currently. This is due to the
previous quirk not being sorted properly, whoopsies. Therefore, only one
has to stay. During AB testing, the configs were found to be close to
identical. Around 20 reboots later, it seems they feature a small pop
when at full volume on boot at an identical probability.

Then, add the Asus Z13 2025 quirk to the list. In the V1 of this series,
the Ally config was used, which (see above) is a bit ambitious. Testing
found that the stock quirk works just as well, so use that instead.

@Stefan: the Z13 is a big launch for Asus, could we do something to
expedite things just for this laptop? As far as Bazzite is concerned,
we shipped the stock quirk as of today, and included the firmware. This
is moreso for mainline distributions.

The Z13 was tested with the following firmware files:

sha256sum *
79cc046b2a1a89fd250dadfb47bdcb8a3c3d7df80452079f64e5417b237f4889  cs35l41-dsp1-spk-cali-10431fb3-l0.bin
3027249f8a340a8fb0034d67e5af8787789c83e9b3623664dab744668272b54e  cs35l41-dsp1-spk-cali-10431fb3-r0.bin
a8f3d1735c03383cd8567713e510034b0f98df0264fa7135e6e8186e0ea346de  cs35l41-dsp1-spk-prot-10431fb3-l0.bin
f0cdcf6d72bc591dec8a7bacba3ad8b46742207807c1e3c7787171de66e6f815  cs35l41-dsp1-spk-prot-10431fb3-r0.bin
e4e73d47203e0badc913b4a1317d48cb0e1b54d7d737f339148068f0cde34b16  cs35l41-dsp1-spk-prot-10431fb3.wmfw

Changelog since V1:
    - Revert Ally X config to use the stock quirk instead
    - Use a stock quirk for the Z13 too

Antheas Kapenekakis (2):
  ALSA: hda/realtek: Remove (revert) duplicate Ally X config
  ALSA: hda/realtek: Fix Asus Z13 2025 audio

 sound/pci/hda/patch_realtek.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Takashi Iwai Feb. 28, 2025, 9:45 a.m. UTC | #1
On Thu, 27 Feb 2025 18:51:05 +0100,
Antheas Kapenekakis wrote:
> 
> The Ally X has two quirks in the kernel currently. This is due to the
> previous quirk not being sorted properly, whoopsies. Therefore, only one
> has to stay. During AB testing, the configs were found to be close to
> identical. Around 20 reboots later, it seems they feature a small pop
> when at full volume on boot at an identical probability.
> 
> Then, add the Asus Z13 2025 quirk to the list. In the V1 of this series,
> the Ally config was used, which (see above) is a bit ambitious. Testing
> found that the stock quirk works just as well, so use that instead.
> 
> @Stefan: the Z13 is a big launch for Asus, could we do something to
> expedite things just for this laptop? As far as Bazzite is concerned,
> we shipped the stock quirk as of today, and included the firmware. This
> is moreso for mainline distributions.
> 
> The Z13 was tested with the following firmware files:
> 
> sha256sum *
> 79cc046b2a1a89fd250dadfb47bdcb8a3c3d7df80452079f64e5417b237f4889  cs35l41-dsp1-spk-cali-10431fb3-l0.bin
> 3027249f8a340a8fb0034d67e5af8787789c83e9b3623664dab744668272b54e  cs35l41-dsp1-spk-cali-10431fb3-r0.bin
> a8f3d1735c03383cd8567713e510034b0f98df0264fa7135e6e8186e0ea346de  cs35l41-dsp1-spk-prot-10431fb3-l0.bin
> f0cdcf6d72bc591dec8a7bacba3ad8b46742207807c1e3c7787171de66e6f815  cs35l41-dsp1-spk-prot-10431fb3-r0.bin
> e4e73d47203e0badc913b4a1317d48cb0e1b54d7d737f339148068f0cde34b16  cs35l41-dsp1-spk-prot-10431fb3.wmfw
> 
> Changelog since V1:
>     - Revert Ally X config to use the stock quirk instead
>     - Use a stock quirk for the Z13 too
> 
> Antheas Kapenekakis (2):
>   ALSA: hda/realtek: Remove (revert) duplicate Ally X config
>   ALSA: hda/realtek: Fix Asus Z13 2025 audio

Applied both patches now to for-linus branch.
I added Fixes tag to the former.


thanks,

Takashi