[0/2] ALSA: usb-audio: scarlett2: Fix device hang with ehci-pci

Message

Geoffrey D. Bennett May 21, 2021, 8:20 a.m. UTC

This patchset fixes a show-stopper bug with the Scarlett Gen 2 mixer
driver not working with the ehci-pci host driver, and improves the
user experience with better driver startup messages.

Patch 1: Fixes the driver hanging the device by using the correct
direction pipe now.

Patch 2: Improves the user experience with more specific enabling
instructions, positive feedback when it is enabled or if
initialisation fails. The previous instructions were incomplete and
didn't confirm that the driver was enabled.

#Cc: [e-mail] please (sorry, not sure if I should be
sending this there myself or if it gets added by Takashi after
review?)

Geoffrey D. Bennett (2):
  ALSA: usb-audio: scarlett2: Fix device hang with ehci-pci
  ALSA: usb-audio: scarlett2: Improve driver startup messages

 sound/usb/mixer_quirks.c        |  2 +-
 sound/usb/mixer_scarlett_gen2.c | 81 +++++++++++++++++++++------------
 sound/usb/mixer_scarlett_gen2.h |  2 +-
 3 files changed, 53 insertions(+), 32 deletions(-)

Comments

Takashi Iwai May 21, 2021, 2:23 p.m. UTC | #1

On Fri, 21 May 2021 10:20:11 +0200,
Geoffrey D. Bennett wrote:
> 
> This patchset fixes a show-stopper bug with the Scarlett Gen 2 mixer
> driver not working with the ehci-pci host driver, and improves the
> user experience with better driver startup messages.
> 
> Patch 1: Fixes the driver hanging the device by using the correct
> direction pipe now.
> 
> Patch 2: Improves the user experience with more specific enabling
> instructions, positive feedback when it is enabled or if
> initialisation fails. The previous instructions were incomplete and
> didn't confirm that the driver was enabled.
> 
> #Cc: [e-mail] please (sorry, not sure if I should be
> sending this there myself or if it gets added by Takashi after
> review?)

No problem, I added manually at applying.

> 
> Geoffrey D. Bennett (2):
>   ALSA: usb-audio: scarlett2: Fix device hang with ehci-pci
>   ALSA: usb-audio: scarlett2: Improve driver startup messages

Applied both patches now.  Thanks.


Takashi