[0/4] ALSA: scarlett2: note gen 3 support + fix four issues

Message

Geoffrey D. Bennett July 22, 2021, 8:11 p.m. UTC

Hi Takashi,

In the sound-5.14-rc1 merge commit log the highlights included:
"Scarlett2 mixer code fixes and enhancements". I think that the new
support for Gen 3 devices is significant enough to be worth
mentioning.

Can you add to the next update a note along the lines of "Support for
Focusrite Scarlett Solo/2i2/4i4/8i6/18i8/18i20 Gen 3 audio interface
proprietary mixer controls"?

This set of patches is relative to v5.14-rc2 and fixes four issues:

1. The Mute/Dim/MSD Mode controls are missing the direction/function
parts of the syntax of standard control names as per
Documentation/sound/designs/control-names.rst

- This could be considered a breaking-stable change if someone is
  relying on the Mute/Dim control names not changing. I think it's
  unlikely to be a problem as this driver is still considered
  experimental and not enabled by default, but if never changing
  control names is important, then you can drop this patch.

2. The Direct Monitor control on the 2i2 interface is an Enum, not a
Switch.

- This changes a control name, but that control was only introduced in
  v5.14-rc1, so not a problem to change it now.

3. Fixes the mute status not being correctly read when the mute button
is pressed.

- Not applicable for stable; those controls were introduced in
  v5.14-rc1.

4. Sends the correct notification on line out and speaker switching
changes.

- Partly applicable to stable, but will need a separate patch.

Thanks,
Geoffrey.

Geoffrey D. Bennett (4):
  ALSA: scarlett2: Fix Mute/Dim/MSD Mode control names
  ALSA: scarlett2: Fix Direct Monitor control name for 2i2
  ALSA: scarlett2: Correct channel mute status after mute button pressed
  ALSA: scarlett2: Fix line out/speaker switching notifications

 sound/usb/mixer_scarlett_gen2.c | 34 +++++++++++++++++++++++----------
 1 file changed, 24 insertions(+), 10 deletions(-)

Comments

Geraldo Nascimento July 22, 2021, 6:30 p.m. UTC | #1

On Thu, Jul 22, 2021 at 8:12 PM Geoffrey D. Bennett <[e-mail]> wrote:
>
> Hi Takashi,
>
> In the sound-5.14-rc1 merge commit log the highlights included:
> "Scarlett2 mixer code fixes and enhancements". I think that the new
> support for Gen 3 devices is significant enough to be worth
> mentioning.

I wholeheartedly agree with Geoffrey, Dr. Iwai.
The commit log highlights are picked up by various media outlets, e.g. Phoronix.

Most of the time these mainstream channels are the ones that will end
up notifying the end-user that new hardware support is available.
It would be not only wise to divulge our efforts that add support and
fix bugs in supported hardware.

It would be kind too, sometimes some piece of Audio hardware is the
one key aspect holding back an user in an OS they don't particularly
like.
I'd go so far and say holding the user hostage, but I'll just leave it
here and end my 2 cents worth of comment.

Thanks,
Geraldo Nascimento

Takashi Iwai July 24, 2021, 8:06 a.m. UTC | #2

On Thu, 22 Jul 2021 22:11:40 +0200,
Geoffrey D. Bennett wrote:
> 
> Hi Takashi,
> 
> In the sound-5.14-rc1 merge commit log the highlights included:
> "Scarlett2 mixer code fixes and enhancements". I think that the new
> support for Gen 3 devices is significant enough to be worth
> mentioning.
> 
> Can you add to the next update a note along the lines of "Support for
> Focusrite Scarlett Solo/2i2/4i4/8i6/18i8/18i20 Gen 3 audio interface
> proprietary mixer controls"?
> 
> This set of patches is relative to v5.14-rc2 and fixes four issues:
> 
> 1. The Mute/Dim/MSD Mode controls are missing the direction/function
> parts of the syntax of standard control names as per
> Documentation/sound/designs/control-names.rst
> 
> - This could be considered a breaking-stable change if someone is
>   relying on the Mute/Dim control names not changing. I think it's
>   unlikely to be a problem as this driver is still considered
>   experimental and not enabled by default, but if never changing
>   control names is important, then you can drop this patch.
> 
> 2. The Direct Monitor control on the 2i2 interface is an Enum, not a
> Switch.
> 
> - This changes a control name, but that control was only introduced in
>   v5.14-rc1, so not a problem to change it now.
> 
> 3. Fixes the mute status not being correctly read when the mute button
> is pressed.
> 
> - Not applicable for stable; those controls were introduced in
>   v5.14-rc1.
> 
> 4. Sends the correct notification on line out and speaker switching
> changes.
> 
> - Partly applicable to stable, but will need a separate patch.
> 
> Thanks,
> Geoffrey.
> 
> Geoffrey D. Bennett (4):
>   ALSA: scarlett2: Fix Mute/Dim/MSD Mode control names
>   ALSA: scarlett2: Fix Direct Monitor control name for 2i2
>   ALSA: scarlett2: Correct channel mute status after mute button pressed
>   ALSA: scarlett2: Fix line out/speaker switching notifications

Applied all four patches now.  Thanks.


Takashi