From patchwork Thu Jul 22 20:11:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Geoffrey D. Bennett" X-Patchwork-Id: 12394609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3268DC4338F for ; Thu, 22 Jul 2021 20:12:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36CBF60EB8 for ; Thu, 22 Jul 2021 20:12:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 36CBF60EB8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=b4.vu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0761116EA; Thu, 22 Jul 2021 22:11:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0761116EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626984769; bh=0jtYoxP4473mEMKL3RMFcmP8UBLSakGGdnB+FYpmim8=; h=Date:From:To:Subject:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=TsZZdlfUlezCNJ2N3V32NLxY11Aaxeqj9uUOaGTQsZctNLFSpWB9hBFXaMI0eEbRi L8ADb4RQ9anvvD03l/gGjvb7hBJlKCTI1IgHbJcugJchcCYT4InxFpzxpfcDIhChSI 5vK07A/BYDMPtqaQV8JfkyOfiUFK+lmdF49KwdxE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8AFECF80227; Thu, 22 Jul 2021 22:11:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 61934F80227; Thu, 22 Jul 2021 22:11:52 +0200 (CEST) Received: from m.b4.vu (m.b4.vu [203.16.231.148]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D2578F80114 for ; Thu, 22 Jul 2021 22:11:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D2578F80114 Received: by m.b4.vu (Postfix, from userid 1000) id A52AA611D167; Fri, 23 Jul 2021 05:41:40 +0930 (ACST) Date: Fri, 23 Jul 2021 05:41:40 +0930 From: "Geoffrey D. Bennett" To: alsa-devel@alsa-project.org, Takashi Iwai Subject: [PATCH 0/4] ALSA: scarlett2: note gen 3 support + fix four issues Message-ID: MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Hin-Tak Leung , Vladimir Sadovnikov X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Takashi, In the sound-5.14-rc1 merge commit log the highlights included: "Scarlett2 mixer code fixes and enhancements". I think that the new support for Gen 3 devices is significant enough to be worth mentioning. Can you add to the next update a note along the lines of "Support for Focusrite Scarlett Solo/2i2/4i4/8i6/18i8/18i20 Gen 3 audio interface proprietary mixer controls"? This set of patches is relative to v5.14-rc2 and fixes four issues: 1. The Mute/Dim/MSD Mode controls are missing the direction/function parts of the syntax of standard control names as per Documentation/sound/designs/control-names.rst - This could be considered a breaking-stable change if someone is relying on the Mute/Dim control names not changing. I think it's unlikely to be a problem as this driver is still considered experimental and not enabled by default, but if never changing control names is important, then you can drop this patch. 2. The Direct Monitor control on the 2i2 interface is an Enum, not a Switch. - This changes a control name, but that control was only introduced in v5.14-rc1, so not a problem to change it now. 3. Fixes the mute status not being correctly read when the mute button is pressed. - Not applicable for stable; those controls were introduced in v5.14-rc1. 4. Sends the correct notification on line out and speaker switching changes. - Partly applicable to stable, but will need a separate patch. Thanks, Geoffrey. Geoffrey D. Bennett (4): ALSA: scarlett2: Fix Mute/Dim/MSD Mode control names ALSA: scarlett2: Fix Direct Monitor control name for 2i2 ALSA: scarlett2: Correct channel mute status after mute button pressed ALSA: scarlett2: Fix line out/speaker switching notifications sound/usb/mixer_scarlett_gen2.c | 34 +++++++++++++++++++++++---------- 1 file changed, 24 insertions(+), 10 deletions(-)