mbox series

[v2,0/2] Make headphone work on Huawei Matebook D15

Message ID cover.1649147890.git.mchehab@kernel.org (mailing list archive)
Headers show
Series Make headphone work on Huawei Matebook D15 | expand

Message

Mauro Carvalho Chehab April 5, 2022, 8:44 a.m. UTC 
At Huawei Matebook D15 two different GPIOs are used to control the output:
	- gpio0 controls the speaker output;
	- gpio1 controls the headphone output.

Changing both at the same time cause spurious events that are mis-interpreted
as input events, causing troubles on apps. So, a delay is needed before turning
on such gpios.

With this patch, plugging a headphone causes a jack event to trigger the speaker
supply, powering down the speaker and powering up the headphone output.
Removing the headphone also triggers the power supply, powering up the speaker
and powering down the headphone.

Mauro Carvalho Chehab (2):
  ASoC: Intel: sof_es8336: support a separate gpio to control headphone
  ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio

 sound/soc/intel/boards/sof_es8336.c | 68 ++++++++++++++++++++++++-----
 1 file changed, 58 insertions(+), 10 deletions(-)

Comments

Hans de Goede April 5, 2022, 9 a.m. UTC | #1 
Hi,

On 4/5/22 10:44, Mauro Carvalho Chehab wrote:
> At Huawei Matebook D15 two different GPIOs are used to control the output:
> 	- gpio0 controls the speaker output;
> 	- gpio1 controls the headphone output.
> 
> Changing both at the same time cause spurious events that are mis-interpreted
> as input events, causing troubles on apps. So, a delay is needed before turning
> on such gpios.
> 
> With this patch, plugging a headphone causes a jack event to trigger the speaker
> supply, powering down the speaker and powering up the headphone output.
> Removing the headphone also triggers the power supply, powering up the speaker
> and powering down the headphone.
> 
> Mauro Carvalho Chehab (2):
>   ASoC: Intel: sof_es8336: support a separate gpio to control headphone
>   ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio

There is something weird with the patches here, at least for me in Thunderbird
both patches show up as nameless attachments to emails with empty bodies.

After saving the attachments the patches look good to me, so:

Acked-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans
Mauro Carvalho Chehab April 5, 2022, 1:48 p.m. UTC | #2 
Em Tue, 5 Apr 2022 11:00:44 +0200
Hans de Goede <hdegoede@redhat.com> escreveu:

> Hi,
> 
> On 4/5/22 10:44, Mauro Carvalho Chehab wrote:
> > At Huawei Matebook D15 two different GPIOs are used to control the output:
> > 	- gpio0 controls the speaker output;
> > 	- gpio1 controls the headphone output.
> > 
> > Changing both at the same time cause spurious events that are mis-interpreted
> > as input events, causing troubles on apps. So, a delay is needed before turning
> > on such gpios.
> > 
> > With this patch, plugging a headphone causes a jack event to trigger the speaker
> > supply, powering down the speaker and powering up the headphone output.
> > Removing the headphone also triggers the power supply, powering up the speaker
> > and powering down the headphone.
> > 
> > Mauro Carvalho Chehab (2):
> >   ASoC: Intel: sof_es8336: support a separate gpio to control headphone
> >   ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio  
> 
> There is something weird with the patches here, at least for me in Thunderbird
> both patches show up as nameless attachments to emails with empty bodies.

Weird... I tested here on Thunderbird (Fedora 35), reading it from the ML
and they opened ok here.

There *is* an issue on such patches though: they ended using my past
e-mail :-) 

I'll re-send those with your ack using the right SoB/From
mchehab@kernel.org.

> 
> After saving the attachments the patches look good to me, so:
> 
> Acked-by: Hans de Goede <hdegoede@redhat.com>

Thanks!

Regards,
Mauro
Hans de Goede April 5, 2022, 1:56 p.m. UTC | #3 
Hi,

On 4/5/22 15:48, Mauro Carvalho Chehab wrote:
> Em Tue, 5 Apr 2022 11:00:44 +0200
> Hans de Goede <hdegoede@redhat.com> escreveu:
> 
>> Hi,
>>
>> On 4/5/22 10:44, Mauro Carvalho Chehab wrote:
>>> At Huawei Matebook D15 two different GPIOs are used to control the output:
>>> 	- gpio0 controls the speaker output;
>>> 	- gpio1 controls the headphone output.
>>>
>>> Changing both at the same time cause spurious events that are mis-interpreted
>>> as input events, causing troubles on apps. So, a delay is needed before turning
>>> on such gpios.
>>>
>>> With this patch, plugging a headphone causes a jack event to trigger the speaker
>>> supply, powering down the speaker and powering up the headphone output.
>>> Removing the headphone also triggers the power supply, powering up the speaker
>>> and powering down the headphone.
>>>
>>> Mauro Carvalho Chehab (2):
>>>   ASoC: Intel: sof_es8336: support a separate gpio to control headphone
>>>   ASoC: Intel: sof_es8336: Huawei Matebook D15 uses a headphone gpio  
>>
>> There is something weird with the patches here, at least for me in Thunderbird
>> both patches show up as nameless attachments to emails with empty bodies.
> 
> Weird... I tested here on Thunderbird (Fedora 35), reading it from the ML
> and they opened ok here.

Yes I checked lore.kernel.org and they look fine there, so as you
said: weird.

> There *is* an issue on such patches though: they ended using my past
> e-mail :-) 
> 
> I'll re-send those with your ack using the right SoB/From
> mchehab@kernel.org.

And in the resend they look fine in my Thunderbird too.

Regards,

Hans