mbox series

[00/14] ALSA: scarlett2: Add support for Vocaster

Message ID cover.1710264833.git.g@b4.vu (mailing list archive)
Headers show
Series ALSA: scarlett2: Add support for Vocaster | expand

Message

Geoffrey D. Bennett March 12, 2024, 6:28 p.m. UTC
Hi Takashi,

This patch series contains:

1-2: Fix to wait for an ACK from the device after sending a command,
before attempting to read the response. This didn't seem to be
necessary previously, but with 4th Gen devices it seems to help with a
rare issue where the device stops responding.

3: Support for reading flash segments from the device.

4-11: Preparation for Vocaster support.

12: Vocaster One and Two support.

13: Add autogain target controls for 4th Gen and Vocaster.

14: Add Bluetooth volume control for Vocaster Two.

Thanks,
Geoffrey.

Geoffrey D. Bennett (14):
  ALSA: scarlett2: Move initialisation code lower in the source
  ALSA: scarlett2: Implement handling of the ACK notification
  ALSA: scarlett2: Add support for reading from flash
  ALSA: scarlett2: Rename gen4_write_addr to param_buf_addr
  ALSA: scarlett2: Add pbuf field to struct scarlett2_config
  ALSA: scarlett2: Add support for config items with size = 32
  ALSA: scarlett2: Add additional input configuration parameters
  ALSA: scarlett2: Define the maximum preamp input gain per-config-set
  ALSA: scarlett2: Define autogain status texts per-config-set
  ALSA: scarlett2: Add input mute controls
  ALSA: scarlett2: Add DSP controls
  ALSA: scarlett2: Add support for Focusrite Vocaster One and Two
  ALSA: scarlett2: Add autogain target controls
  ALSA: scarlett2: Add Bluetooth volume control for Vocaster Two

 sound/usb/mixer_quirks.c    |    2 +
 sound/usb/mixer_scarlett2.c | 2757 ++++++++++++++++++++++++++++-------
 2 files changed, 2235 insertions(+), 524 deletions(-)

Comments

Takashi Iwai March 12, 2024, 7 p.m. UTC | #1
On Tue, 12 Mar 2024 19:28:52 +0100,
Geoffrey D. Bennett wrote:
> 
> Hi Takashi,
> 
> This patch series contains:
> 
> 1-2: Fix to wait for an ACK from the device after sending a command,
> before attempting to read the response. This didn't seem to be
> necessary previously, but with 4th Gen devices it seems to help with a
> rare issue where the device stops responding.
> 
> 3: Support for reading flash segments from the device.
> 
> 4-11: Preparation for Vocaster support.
> 
> 12: Vocaster One and Two support.
> 
> 13: Add autogain target controls for 4th Gen and Vocaster.
> 
> 14: Add Bluetooth volume control for Vocaster Two.

As the merge window was already opened, I postpone this series to
6.10.  If there is any fix that should be taken to 6.9, please submit
separately.


thanks,

Takashi

> 
> Thanks,
> Geoffrey.
> 
> Geoffrey D. Bennett (14):
>   ALSA: scarlett2: Move initialisation code lower in the source
>   ALSA: scarlett2: Implement handling of the ACK notification
>   ALSA: scarlett2: Add support for reading from flash
>   ALSA: scarlett2: Rename gen4_write_addr to param_buf_addr
>   ALSA: scarlett2: Add pbuf field to struct scarlett2_config
>   ALSA: scarlett2: Add support for config items with size = 32
>   ALSA: scarlett2: Add additional input configuration parameters
>   ALSA: scarlett2: Define the maximum preamp input gain per-config-set
>   ALSA: scarlett2: Define autogain status texts per-config-set
>   ALSA: scarlett2: Add input mute controls
>   ALSA: scarlett2: Add DSP controls
>   ALSA: scarlett2: Add support for Focusrite Vocaster One and Two
>   ALSA: scarlett2: Add autogain target controls
>   ALSA: scarlett2: Add Bluetooth volume control for Vocaster Two
> 
>  sound/usb/mixer_quirks.c    |    2 +
>  sound/usb/mixer_scarlett2.c | 2757 ++++++++++++++++++++++++++++-------
>  2 files changed, 2235 insertions(+), 524 deletions(-)
> 
> -- 
> 2.43.0
>
Geoffrey D. Bennett March 14, 2024, 5:41 p.m. UTC | #2
Hi Takashi,

On Tue, Mar 12, 2024 at 08:00:42PM +0100, Takashi Iwai wrote:
> On Tue, 12 Mar 2024 19:28:52 +0100,
> Geoffrey D. Bennett wrote:
> > 
> > Hi Takashi,
> > 
> > This patch series contains:
> > 
> > 1-2: Fix to wait for an ACK from the device after sending a command,
> > before attempting to read the response. This didn't seem to be
> > necessary previously, but with 4th Gen devices it seems to help with a
> > rare issue where the device stops responding.
> > 
> > 3: Support for reading flash segments from the device.
> > 
> > 4-11: Preparation for Vocaster support.
> > 
> > 12: Vocaster One and Two support.
> > 
> > 13: Add autogain target controls for 4th Gen and Vocaster.
> > 
> > 14: Add Bluetooth volume control for Vocaster Two.
> 
> As the merge window was already opened, I postpone this series to
> 6.10.  If there is any fix that should be taken to 6.9, please submit
> separately.

Okay, thanks, I'll resubmit separately fixes for 6.9, and please don't
apply any of these for 6.10 yet; I'll submit a v2 later.

Thanks,
Geoffrey.
Takashi Iwai April 18, 2024, 6:35 a.m. UTC | #3
On Tue, 12 Mar 2024 19:28:52 +0100,
Geoffrey D. Bennett wrote:
> 
> Hi Takashi,
> 
> This patch series contains:
> 
> 1-2: Fix to wait for an ACK from the device after sending a command,
> before attempting to read the response. This didn't seem to be
> necessary previously, but with 4th Gen devices it seems to help with a
> rare issue where the device stops responding.
> 
> 3: Support for reading flash segments from the device.
> 
> 4-11: Preparation for Vocaster support.
> 
> 12: Vocaster One and Two support.
> 
> 13: Add autogain target controls for 4th Gen and Vocaster.
> 
> 14: Add Bluetooth volume control for Vocaster Two.
> 
> Thanks,
> Geoffrey.
> 
> Geoffrey D. Bennett (14):
>   ALSA: scarlett2: Move initialisation code lower in the source
>   ALSA: scarlett2: Implement handling of the ACK notification
>   ALSA: scarlett2: Add support for reading from flash
>   ALSA: scarlett2: Rename gen4_write_addr to param_buf_addr
>   ALSA: scarlett2: Add pbuf field to struct scarlett2_config
>   ALSA: scarlett2: Add support for config items with size = 32
>   ALSA: scarlett2: Add additional input configuration parameters
>   ALSA: scarlett2: Define the maximum preamp input gain per-config-set
>   ALSA: scarlett2: Define autogain status texts per-config-set
>   ALSA: scarlett2: Add input mute controls
>   ALSA: scarlett2: Add DSP controls
>   ALSA: scarlett2: Add support for Focusrite Vocaster One and Two
>   ALSA: scarlett2: Add autogain target controls
>   ALSA: scarlett2: Add Bluetooth volume control for Vocaster Two

Now all merged to for-next branch.  Thanks.


Takashi