diff mbox

ASoC: max98090: make REVISION_ID readable

Message ID 1392335664-6586-1-git-send-email-swarren@wwwdotorg.org (mailing list archive)
State Accepted
Headers show

Commit Message

Stephen Warren Feb. 13, 2014, 11:54 p.m. UTC 
From: Stephen Warren <swarren@nvidia.com>

The REVISION_ID register is not currently marked readable. snd_soc_read()
refuses to read the register, and hence probe() fails.

Fixes: d4807ad2c4c0 ("regmap: Check readable regs in _regmap_read")
[exposed the bug, by checking for readability]
Fixes: 685e42154dcf ("ASoC: Replace max98090 Device Driver")
[left out this register from the readable list]
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 sound/soc/codecs/max98090.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown Feb. 16, 2014, 1:09 a.m. UTC | #1 
On Thu, Feb 13, 2014 at 04:54:24PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> The REVISION_ID register is not currently marked readable. snd_soc_read()
> refuses to read the register, and hence probe() fails.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
index 51f9b3d16b41..141091c62db5 100644
--- a/sound/soc/codecs/max98090.c
+++ b/sound/soc/codecs/max98090.c
@@ -336,6 +336,7 @@  static bool max98090_readable_register(struct device *dev, unsigned int reg)
 	case M98090_REG_RECORD_TDM_SLOT:
 	case M98090_REG_SAMPLE_RATE:
 	case M98090_REG_DMIC34_BIQUAD_BASE ... M98090_REG_DMIC34_BIQUAD_BASE + 0x0E:
+	case M98090_REG_REVISION_ID:
 		return true;
 	default:
 		return false;