diff mbox

[PATCHv2] ASoC: Intel: Baytrail: Fix implicit declaration of function 'memcpy_fromio'

Message ID 1393421506-2411-1-git-send-email-jarkko.nikula@linux.intel.com (mailing list archive)
State Accepted
Commit a6cf8f7b53fff6b5e3463793aa9885e133e7ef86
Headers show

Commit Message

Jarkko Nikula Feb. 26, 2014, 1:31 p.m. UTC
Some kernel configurations can cause following build error:

sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
  memcpy_fromio(&fw_tstamp,
  ^
cc1: some warnings being treated as errors

Fix this by including <linux/io.h> explicitly.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
v2: including <linux/io.h> instead of <asm/io.h>. Thanks to Takashi Iwai for
noticing (checkpatch.pl tells it too).

Also sst-dsp., sst-baytrail-dsp.c and sst-haswell-dsp.c are using
memcpy_fromio/_toio but there <asm/io.h> seems to come via
<linux/dma-mapping.h> or <linux/io.h> so I didn't touch them.
---
 sound/soc/intel/sst-baytrail-ipc.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mark Brown Feb. 26, 2014, 2:47 p.m. UTC | #1
On Wed, Feb 26, 2014 at 03:31:46PM +0200, Jarkko Nikula wrote:
> Some kernel configurations can cause following build error:
> 
> sound/soc/intel/sst-baytrail-ipc.c: In function ‘sst_byt_get_dsp_position’:
> sound/soc/intel/sst-baytrail-ipc.c:744:2: error: implicit declaration of function ‘memcpy_fromio’ [-Werror=implicit-function-declaration]
>   memcpy_fromio(&fw_tstamp,
>   ^
> cc1: some warnings being treated as errors

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/intel/sst-baytrail-ipc.c b/sound/soc/intel/sst-baytrail-ipc.c
index 8c91a68b90bc..c12e194bbc6b 100644
--- a/sound/soc/intel/sst-baytrail-ipc.c
+++ b/sound/soc/intel/sst-baytrail-ipc.c
@@ -26,6 +26,7 @@ 
 #include <linux/platform_device.h>
 #include <linux/kthread.h>
 #include <linux/firmware.h>
+#include <linux/io.h>
 #include <asm/div64.h>
 
 #include "sst-baytrail-ipc.h"