| Message ID | 1399365699-21084-1-git-send-email-Guangyu.Chen@freescale.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e9b383dc940f4cba6876887ecb47df3082ec925e |
| Headers | show |
On Tue, May 06, 2014 at 04:41:39PM +0800, Nicolin Chen wrote: > We should not copy the return value into this val since it's supposed to > get the value of the register not the success result of regmap_read(). > Thus fix it. Applied, thanks.
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index b912d45..9ea2dd4 100644 --- a/sound/soc/fsl/fsl_spdif.c +++ b/sound/soc/fsl/fsl_spdif.c @@ -762,7 +762,7 @@ static int fsl_spdif_vbit_get(struct snd_kcontrol *kcontrol, struct regmap *regmap = spdif_priv->regmap; u32 val; - val = regmap_read(regmap, REG_SPDIF_SIS, &val); + regmap_read(regmap, REG_SPDIF_SIS, &val); ucontrol->value.integer.value[0] = (val & INT_VAL_NOGOOD) != 0; regmap_write(regmap, REG_SPDIF_SIC, INT_VAL_NOGOOD);
We should not copy the return value into this val since it's supposed to get the value of the register not the success result of regmap_read(). Thus fix it. Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com> --- sound/soc/fsl/fsl_spdif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)