diff mbox

[PATCHv2] ASoC: Intel: Fix Baytrail SST DSP firmware loading

Message ID 1399985166-29055-1-git-send-email-jarkko.nikula@linux.intel.com (mailing list archive)
State Accepted
Commit cffd6665f57ed18f4be9185c4330c8c98c22e201
Headers show

Commit Message

Jarkko Nikula May 13, 2014, 12:46 p.m. UTC
Commit 10df350977b1 ("ASoC: Intel: Fix Audio DSP usage when IOMMU is
enabled.") caused following regression in Baytrail SST:

baytrail-pcm-audio baytrail-pcm-audio: error: DMA alloc failed
baytrail-pcm-audio baytrail-pcm-audio: error: failed to load firmware

Fix this by calling dma_coerce_mask_and_coherent() in sst_byt_init() with
the same dma_dev device what is now used in sst_fw_new() when allocating the
DMA buffer.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
For fix/intel branch.
---
 sound/soc/intel/sst-baytrail-dsp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown May 13, 2014, 5:21 p.m. UTC | #1
On Tue, May 13, 2014 at 03:46:06PM +0300, Jarkko Nikula wrote:
> Commit 10df350977b1 ("ASoC: Intel: Fix Audio DSP usage when IOMMU is
> enabled.") caused following regression in Baytrail SST:

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/intel/sst-baytrail-dsp.c b/sound/soc/intel/sst-baytrail-dsp.c
index a50bf7fc0e3a..adf0aca5aca6 100644
--- a/sound/soc/intel/sst-baytrail-dsp.c
+++ b/sound/soc/intel/sst-baytrail-dsp.c
@@ -324,7 +324,7 @@  static int sst_byt_init(struct sst_dsp *sst, struct sst_pdata *pdata)
 	memcpy_toio(sst->addr.lpe + SST_BYT_MAILBOX_OFFSET,
 	       &pdata->fw_base, sizeof(u32));
 
-	ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32));
+	ret = dma_coerce_mask_and_coherent(sst->dma_dev, DMA_BIT_MASK(32));
 	if (ret)
 		return ret;