diff mbox

[4/6] fireworks: Remove a constant over width to which it's applied

Message ID 1401863137-15103-5-git-send-email-o-takashi@sakamocchi.jp (mailing list archive)
State Not Applicable
Commit f3479150923d164470eef7f33b0192f82de51403
Headers show

Commit Message

Takashi Sakamoto June 4, 2014, 6:25 a.m. UTC
The constants of enum snd_efw_grp_type is for struct snd_efw_phys_grp.type.
But this member is 1 byte. Although the value is between 0x00-0xff, a constant
has 0x10000. This constant is meaningless.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 sound/firewire/fireworks/fireworks.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Takashi Iwai June 4, 2014, 12:40 p.m. UTC | #1
At Wed,  4 Jun 2014 15:25:35 +0900,
Takashi Sakamoto wrote:
> 
> The constants of enum snd_efw_grp_type is for struct snd_efw_phys_grp.type.
> But this member is 1 byte. Although the value is between 0x00-0xff, a constant
> has 0x10000. This constant is meaningless.
> 
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

Applied, thanks.


Takashi

> ---
>  sound/firewire/fireworks/fireworks.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/sound/firewire/fireworks/fireworks.h b/sound/firewire/fireworks/fireworks.h
> index d2b36be..4f0201a 100644
> --- a/sound/firewire/fireworks/fireworks.h
> +++ b/sound/firewire/fireworks/fireworks.h
> @@ -162,7 +162,6 @@ enum snd_efw_grp_type {
>  	SND_EFW_CH_TYPE_GUITAR			= 7,
>  	SND_EFW_CH_TYPE_PIEZO_GUITAR		= 8,
>  	SND_EFW_CH_TYPE_GUITAR_STRING		= 9,
> -	SND_EFW_CH_TYPE_VIRTUAL			= 0x10000,
>  	SND_EFW_CH_TYPE_DUMMY
>  };
>  struct snd_efw_phys_meters {
> -- 
> 1.8.3.2
>
diff mbox

Patch

diff --git a/sound/firewire/fireworks/fireworks.h b/sound/firewire/fireworks/fireworks.h
index d2b36be..4f0201a 100644
--- a/sound/firewire/fireworks/fireworks.h
+++ b/sound/firewire/fireworks/fireworks.h
@@ -162,7 +162,6 @@  enum snd_efw_grp_type {
 	SND_EFW_CH_TYPE_GUITAR			= 7,
 	SND_EFW_CH_TYPE_PIEZO_GUITAR		= 8,
 	SND_EFW_CH_TYPE_GUITAR_STRING		= 9,
-	SND_EFW_CH_TYPE_VIRTUAL			= 0x10000,
 	SND_EFW_CH_TYPE_DUMMY
 };
 struct snd_efw_phys_meters {