From patchwork Fri Jul 11 13:45:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 4534641 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 51A379F392 for ; Fri, 11 Jul 2014 14:10:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 18BAB2017E for ; Fri, 11 Jul 2014 14:10:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id D866F20158 for ; Fri, 11 Jul 2014 14:09:58 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 9159F2651A9; Fri, 11 Jul 2014 16:09:56 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_DNS_FOR_FROM, UNPARSEABLE_RELAY autolearn=no version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id 0815D2651D3; Fri, 11 Jul 2014 16:01:50 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1F65B265308; Fri, 11 Jul 2014 16:01:46 +0200 (CEST) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by alsa0.perex.cz (Postfix) with ESMTP id EEBD52651B4 for ; Fri, 11 Jul 2014 15:45:32 +0200 (CEST) Received: from wuerfel.lan. (HSI-KBW-134-3-133-35.hsi14.kabel-badenwuerttemberg.de [134.3.133.35]) by mrelayeu.kundenserver.de (node=mreue103) with ESMTP (Nemesis) id 0M2XRt-1WmQKJ2hbp-00sQWp; Fri, 11 Jul 2014 15:45:26 +0200 From: Arnd Bergmann To: alsa-devel@alsa-project.org Date: Fri, 11 Jul 2014 15:45:04 +0200 Message-Id: <1405086308-1461192-3-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1405086308-1461192-1-git-send-email-arnd@arndb.de> References: <1405086308-1461192-1-git-send-email-arnd@arndb.de> X-Provags-ID: V02:K0:RMPI5EY0zGZrTSVkRIJ36NJJUP0Qw5EK2uVcaAKtbQq FLG6+5634TSMZavwZc0I8MGRvtiGN+/BOpKaPC8snoS6QTzF6B qlD4cDbc+fGegcYlarU1HnAMqOKi7Qo6W1hGSH1UhYo7wOK0x2 iR96+TO1RT9Iif2IjAefMcUbVXl6zL3AMyuZDzBrJG+zzCzmmA sVaPHKFNXofRUUjQ+txz1XV+NNNTMeC3ikWSeM01CIJR7sJJFm zK/fCMBKQg81pb34qKNqRlAVg+VTyYpKu0PhSIRB+tp0sszfrz mWdJ5EK94oYaQuM8lyEvhqRSSqa5zsMUMgXbo1U5wB4NYpg28q oQLeiDm6IZZtCqhlq3pXReeNi6MZIK9YeV4MzbL9c Cc: t.figa@samsung.com, broonie@kernel.org, Arnd Bergmann , lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH 1/4] ASoC: samsung: add explicit i2c/spi dependencies X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP I got another build error from SND_SOC_SMARTQ selecting SND_SOC_WM8750 without ensuring that I2C is enabled, in this example, i2c is a loadable module: sound/built-in.o: In function `wm8750_i2c_probe': :(.text+0x3e6c0): undefined reference to `devm_regmap_init_i2c' sound/built-in.o: In function `wm8750_exit': :(.exit.text+0x3f4): undefined reference to `i2c_del_driver' sound/built-in.o: In function `wm8750_modinit': :(.init.text+0x13d0): undefined reference to `i2c_register_driver' This changes the samsund ASoC Kconfig to have explicit I2C dependencies for each driver that uses an i2c bus and SPI dependencies for the ones using those. Signed-off-by: Arnd Bergmann --- sound/soc/samsung/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/samsung/Kconfig b/sound/soc/samsung/Kconfig index 2c4786c6fe91..7622af82ac4f 100644 --- a/sound/soc/samsung/Kconfig +++ b/sound/soc/samsung/Kconfig @@ -49,7 +49,7 @@ config SND_SOC_SAMSUNG_NEO1973_WM8753 config SND_SOC_SAMSUNG_JIVE_WM8750 tristate "SoC I2S Audio support for Jive" - depends on SND_SOC_SAMSUNG && MACH_JIVE + depends on SND_SOC_SAMSUNG && MACH_JIVE && I2C select SND_SOC_WM8750 select SND_S3C2412_SOC_I2S help @@ -148,7 +148,7 @@ config SND_SOC_SAMSUNG_SMDK_WM9713 config SND_SOC_SMARTQ tristate "SoC I2S Audio support for SmartQ board" - depends on SND_SOC_SAMSUNG && MACH_SMARTQ + depends on SND_SOC_SAMSUNG && MACH_SMARTQ && I2C select SND_SAMSUNG_I2S select SND_SOC_WM8750 @@ -200,7 +200,7 @@ config SND_SOC_SPEYSIDE config SND_SOC_TOBERMORY tristate "Audio support for Wolfson Tobermory" - depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410 && INPUT + depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410 && INPUT && I2C select SND_SAMSUNG_I2S select SND_SOC_WM8962 @@ -216,7 +216,7 @@ config SND_SOC_BELLS config SND_SOC_LOWLAND tristate "Audio support for Wolfson Lowland" - depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410 + depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410 && I2C select SND_SAMSUNG_I2S select SND_SOC_WM5100 select SND_SOC_WM9081