| Message ID | 1406041328-20821-1-git-send-email-o-takashi@sakamocchi.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | eb12f72ee7245ca207818b9efd10be2641494502 |
| Delegated to: | Takashi Iwai |
| Headers | show |
At Wed, 23 Jul 2014 00:02:08 +0900, Takashi Sakamoto wrote: > > This commit is a supplement to my previous patch. > http://mailman.alsa-project.org/pipermail/alsa-devel/2014-July/079190.html > > The special_clk_ctl_put() still returns 0 in error handling case. It should > return -EINVAL. > > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Applied, thanks. Takashi > --- > sound/firewire/bebob/bebob_maudio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c > index d6d6ff8..70faa3a 100644 > --- a/sound/firewire/bebob/bebob_maudio.c > +++ b/sound/firewire/bebob/bebob_maudio.c > @@ -381,7 +381,7 @@ static int special_clk_ctl_put(struct snd_kcontrol *kctl, > > id = uval->value.enumerated.item[0]; > if (id >= ARRAY_SIZE(special_clk_labels)) > - return 0; > + return -EINVAL; > > mutex_lock(&bebob->mutex); > > -- > 1.9.1 >
diff --git a/sound/firewire/bebob/bebob_maudio.c b/sound/firewire/bebob/bebob_maudio.c index d6d6ff8..70faa3a 100644 --- a/sound/firewire/bebob/bebob_maudio.c +++ b/sound/firewire/bebob/bebob_maudio.c @@ -381,7 +381,7 @@ static int special_clk_ctl_put(struct snd_kcontrol *kctl, id = uval->value.enumerated.item[0]; if (id >= ARRAY_SIZE(special_clk_labels)) - return 0; + return -EINVAL; mutex_lock(&bebob->mutex);
This commit is a supplement to my previous patch. http://mailman.alsa-project.org/pipermail/alsa-devel/2014-July/079190.html The special_clk_ctl_put() still returns 0 in error handling case. It should return -EINVAL. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> --- sound/firewire/bebob/bebob_maudio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)