diff mbox

ASoC: fsl: fsl_asrc: Select SND_SOC_GENERIC_DMAENGINE_PCM

Message ID 1406730426-11023-1-git-send-email-festevam@gmail.com (mailing list archive)
State Accepted
Commit bdb9eb49671566afb9ca2025752f57d0e1a6b2a3
Headers show

Commit Message

Fabio Estevam July 30, 2014, 2:27 p.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

Building a kernel with SND_SOC_GENERIC_DMAENGINE_PCM=n leads to the following
error:

ERROR: "snd_dmaengine_pcm_prepare_slave_config" [sound/soc/fsl/snd-soc-fsl-asrc.ko] undefined!

Let SND_SOC_FSL_ASRC select SND_SOC_GENERIC_DMAENGINE_PCM in order to fix such
error.

Reported-by: kbuild test robot <fengguang.wu@intel.com> 
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 sound/soc/fsl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Nicolin Chen July 30, 2014, 3:08 p.m. UTC | #1 
Oops
....I just found that all kbuild mails were sent to this
mailbox
as I changed the address
 for recent patches...

Fabio, thank you for covering me

.
Nicolin

On Wed, Jul 30, 2014 at 10:27 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Building a kernel with SND_SOC_GENERIC_DMAENGINE_PCM=n leads to the
following
> error:
>
> ERROR: "snd_dmaengine_pcm_prepare_slave_config"
[sound/soc/fsl/snd-soc-fsl-asrc.ko] undefined!
>
> Let SND_SOC_FSL_ASRC select SND_SOC_GENERIC_DMAENGINE_PCM in order to fix
such
> error.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  sound/soc/fsl/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 2fb8a43..f54a8fc 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -5,6 +5,7 @@ comment "Common SoC Audio options for Freescale CPUs:"
>  config SND_SOC_FSL_ASRC
>         tristate "Asynchronous Sample Rate Converter (ASRC) module
support"
>         select REGMAP_MMIO
> +       select SND_SOC_GENERIC_DMAENGINE_PCM
>         help
>           Say Y if you want to add Asynchronous Sample Rate Converter
(ASRC)
>           support for the Freescale CPUs.
> --
> 1.9.1
>
Mark Brown July 30, 2014, 11:04 p.m. UTC | #2 
On Wed, Jul 30, 2014 at 11:27:06AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Building a kernel with SND_SOC_GENERIC_DMAENGINE_PCM=n leads to the following
> error:

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 2fb8a43..f54a8fc 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -5,6 +5,7 @@  comment "Common SoC Audio options for Freescale CPUs:"
 config SND_SOC_FSL_ASRC
 	tristate "Asynchronous Sample Rate Converter (ASRC) module support"
 	select REGMAP_MMIO
+	select SND_SOC_GENERIC_DMAENGINE_PCM
 	help
 	  Say Y if you want to add Asynchronous Sample Rate Converter (ASRC)
 	  support for the Freescale CPUs.