diff mbox

[1/3] ASoC: Intel: Fix to use byte control interface

Message ID 1407144861-30475-2-git-send-email-subhransu.s.prusty@intel.com (mailing list archive)
State Accepted
Commit ea5edfe2f1ce5b2254a5ec4c1bb224fac48c3153
Headers show

Commit Message

Subhransu S. Prusty Aug. 4, 2014, 9:34 a.m. UTC 
From: Vinod Koul <vinod.koul@intel.com>

Using a byte control interface instead of generic_params ioctl.

Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/sst-mfld-platform.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Mark Brown Aug. 7, 2014, 11:58 a.m. UTC | #1 
On Mon, Aug 04, 2014 at 03:04:19PM +0530, Subhransu S. Prusty wrote:
> From: Vinod Koul <vinod.koul@intel.com>
> 
> Using a byte control interface instead of generic_params ioctl.

Applied all, thanks.  This is a bit confusing since it's called a fix
but it's not actually a bug fix.

> 
> Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

The signoffs should really be in the other order - if you're passing on
someone else's code you need to add your signoff after theirs.
diff mbox

Patch

diff --git a/sound/soc/intel/sst-mfld-platform.h b/sound/soc/intel/sst-mfld-platform.h
index 6c6a42c08e24..cc3a088df7dd 100644
--- a/sound/soc/intel/sst-mfld-platform.h
+++ b/sound/soc/intel/sst-mfld-platform.h
@@ -63,9 +63,7 @@  enum sst_controls {
 	SST_SND_BUFFER_POINTER =	0x05,
 	SST_SND_STREAM_INIT =		0x06,
 	SST_SND_START	 =		0x07,
-	SST_SET_BYTE_STREAM =           0x100A,
-	SST_GET_BYTE_STREAM =           0x100B,
-	SST_MAX_CONTROLS = SST_GET_BYTE_STREAM,
+	SST_MAX_CONTROLS = 		0x07,
 };
 
 enum sst_stream_ops {
@@ -129,7 +127,7 @@  struct compress_sst_ops {
 struct sst_ops {
 	int (*open) (struct snd_sst_params *str_param);
 	int (*device_control) (int cmd, void *arg);
-	int (*set_generic_params)(enum sst_controls cmd, void *arg);
+	int (*send_byte_stream)(struct snd_sst_bytes_v2 *bytes);
 	int (*close) (unsigned int str_id);
 };