diff mbox

[8/14] ASoC: rsnd: delete unneeded test before of_node_put

Message ID 1407492475-26283-8-git-send-email-Julia.Lawall@lip6.fr (mailing list archive)
State Accepted
Commit a493b6a637e9d8e828d7ed4be4bdf24dfd1f9250
Headers show

Commit Message

Julia Lawall Aug. 8, 2014, 10:07 a.m. UTC 
From: Julia Lawall <Julia.Lawall@lip6.fr>

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 sound/soc/sh/rcar/core.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Mark Brown Aug. 13, 2014, 11:14 a.m. UTC | #1 
On Fri, Aug 08, 2014 at 12:07:49PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Of_node_put supports NULL as its argument, so the initial test is not
> necessary.

Applied, thanks.
diff mbox

Patch

diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index 19f7896..1922ec5 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -798,10 +798,8 @@  if (name##_node) {							\
 			mod_parse(src);
 			mod_parse(dvc);
 
-			if (playback)
-				of_node_put(playback);
-			if (capture)
-				of_node_put(capture);
+			of_node_put(playback);
+			of_node_put(capture);
 		}
 
 		dai_i++;