| Message ID | 1408264747-26357-1-git-send-email-o-takashi@sakamocchi.jp (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Takashi Iwai |
| Headers | show |
At Sun, 17 Aug 2014 17:39:07 +0900, Takashi Sakamoto wrote: > > Some members in this enumerated type has not updated for 9 years, although > kernel-drivers added them during this period. This commit adds them following > to a commit 87df9f3 'sync include/asound/asound.h with 3.17-rc1 kernel'. > > Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> > --- > include/hwdep.h | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/include/hwdep.h b/include/hwdep.h > index ab12822..6ec421c 100644 > --- a/include/hwdep.h > +++ b/include/hwdep.h > @@ -68,8 +68,13 @@ typedef enum _snd_hwdep_iface { > SND_HWDEP_IFACE_USX2Y_PCM, /**< Tascam US122, US224 & US428 raw USB PCM */ > SND_HWDEP_IFACE_PCXHR, /**< Digigram PCXHR */ > SND_HWDEP_IFACE_SB_RC, /**< SB Extigy/Audigy2NX remote control */ > - > - SND_HWDEP_IFACE_LAST = SND_HWDEP_IFACE_SB_RC /**< last known hwdep interface */ > + SNDRV_HWDEP_IFACE_HDA, /* HD-audio */ > + SNDRV_HWDEP_IFACE_USB_STREAM, /* direct access to usb stream */ > + SNDRV_HWDEP_IFACE_FW_DICE, /* TC DICE FireWire device */ > + SNDRV_HWDEP_IFACE_FW_FIREWORKS, /* Echo Audio Fireworks based device */ > + SNDRV_HWDEP_IFACE_FW_BEBOB, /* BridgeCo BeBoB based device */ These must be SND_ prefix. And don't forget to have doxygen comments like others. Please submit the fixed patch again. thanks, Takashi > + > + SND_HWDEP_IFACE_LAST = SND_HWDEP_IFACE_FW_BEBOB /**< last known hwdep interface */ > } snd_hwdep_iface_t; > > /** open for reading */ > -- > 1.9.1 >
On Aug 18 2014 17:54, Takashi Iwai wrote: >> diff --git a/include/hwdep.h b/include/hwdep.h >> index ab12822..6ec421c 100644 >> --- a/include/hwdep.h >> +++ b/include/hwdep.h >> @@ -68,8 +68,13 @@ typedef enum _snd_hwdep_iface { >> SND_HWDEP_IFACE_USX2Y_PCM, /**< Tascam US122, US224 & US428 raw USB PCM */ >> SND_HWDEP_IFACE_PCXHR, /**< Digigram PCXHR */ >> SND_HWDEP_IFACE_SB_RC, /**< SB Extigy/Audigy2NX remote control */ >> - >> - SND_HWDEP_IFACE_LAST = SND_HWDEP_IFACE_SB_RC /**< last known hwdep interface */ >> + SNDRV_HWDEP_IFACE_HDA, /* HD-audio */ >> + SNDRV_HWDEP_IFACE_USB_STREAM, /* direct access to usb stream */ >> + SNDRV_HWDEP_IFACE_FW_DICE, /* TC DICE FireWire device */ >> + SNDRV_HWDEP_IFACE_FW_FIREWORKS, /* Echo Audio Fireworks based device */ >> + SNDRV_HWDEP_IFACE_FW_BEBOB, /* BridgeCo BeBoB based device */ > > These must be SND_ prefix. And don't forget to have doxygen comments > like others. Please submit the fixed patch again. Oh, indeed. I might lose enough notices when posted... Thanks for your comment. Regards Takashi Sakamoto o-takashi@sakamocchi.jp
diff --git a/include/hwdep.h b/include/hwdep.h index ab12822..6ec421c 100644 --- a/include/hwdep.h +++ b/include/hwdep.h @@ -68,8 +68,13 @@ typedef enum _snd_hwdep_iface { SND_HWDEP_IFACE_USX2Y_PCM, /**< Tascam US122, US224 & US428 raw USB PCM */ SND_HWDEP_IFACE_PCXHR, /**< Digigram PCXHR */ SND_HWDEP_IFACE_SB_RC, /**< SB Extigy/Audigy2NX remote control */ - - SND_HWDEP_IFACE_LAST = SND_HWDEP_IFACE_SB_RC /**< last known hwdep interface */ + SNDRV_HWDEP_IFACE_HDA, /* HD-audio */ + SNDRV_HWDEP_IFACE_USB_STREAM, /* direct access to usb stream */ + SNDRV_HWDEP_IFACE_FW_DICE, /* TC DICE FireWire device */ + SNDRV_HWDEP_IFACE_FW_FIREWORKS, /* Echo Audio Fireworks based device */ + SNDRV_HWDEP_IFACE_FW_BEBOB, /* BridgeCo BeBoB based device */ + + SND_HWDEP_IFACE_LAST = SND_HWDEP_IFACE_FW_BEBOB /**< last known hwdep interface */ } snd_hwdep_iface_t; /** open for reading */
Some members in this enumerated type has not updated for 9 years, although kernel-drivers added them during this period. This commit adds them following to a commit 87df9f3 'sync include/asound/asound.h with 3.17-rc1 kernel'. Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> --- include/hwdep.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)